[SPARK-19707][Core] Improve the invalid path check for sc.addJar #17038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I97c3fa0b0c2c1e9584d7d3abd30e352266f116be
|
Test build #73339 has finished for PR 17038 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #73347 has finished for PR 17038 at commit
|
srowen
approved these changes
Feb 23, 2017
Contributor
|
LGTM. retest this please |
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #73387 has finished for PR 17038 at commit
|
Contributor
|
Merging to master (2.1 if no conflicts). |
asfgit
pushed a commit
that referenced
this pull request
Feb 24, 2017
## What changes were proposed in this pull request?
Currently in Spark there're two issues when we add jars with invalid path:
* If the jar path is a empty string {--jar ",dummy.jar"}, then Spark will resolve it to the current directory path and add to classpath / file server, which is unwanted. This is happened in our programatic way to submit Spark application. From my understanding Spark should defensively filter out such empty path.
* If the jar path is a invalid path (file doesn't exist), `addJar` doesn't check it and will still add to file server, the exception will be delayed until job running. Actually this local path could be checked beforehand, no need to wait until task running. We have similar check in `addFile`, but lacks similar similar mechanism in `addJar`.
## How was this patch tested?
Add unit test and local manual verification.
Author: jerryshao <[email protected]>
Closes #17038 from jerryshao/SPARK-19707.
(cherry picked from commit b0a8c16)
Signed-off-by: Marcelo Vanzin <[email protected]>
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
## What changes were proposed in this pull request?
Currently in Spark there're two issues when we add jars with invalid path:
* If the jar path is a empty string {--jar ",dummy.jar"}, then Spark will resolve it to the current directory path and add to classpath / file server, which is unwanted. This is happened in our programatic way to submit Spark application. From my understanding Spark should defensively filter out such empty path.
* If the jar path is a invalid path (file doesn't exist), `addJar` doesn't check it and will still add to file server, the exception will be delayed until job running. Actually this local path could be checked beforehand, no need to wait until task running. We have similar check in `addFile`, but lacks similar similar mechanism in `addJar`.
## How was this patch tested?
Add unit test and local manual verification.
Author: jerryshao <[email protected]>
Closes apache#17038 from jerryshao/SPARK-19707.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently in Spark there're two issues when we add jars with invalid path:
addJardoesn't check it and will still add to file server, the exception will be delayed until job running. Actually this local path could be checked beforehand, no need to wait until task running. We have similar check inaddFile, but lacks similar similar mechanism inaddJar.How was this patch tested?
Add unit test and local manual verification.