Skip to content

Conversation

@cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

to be consistent with the scala API, we should also add contains to Column in pyspark.

How was this patch tested?

updated unit test

@cloud-fan
Copy link
Contributor Author

cc @davies

@SparkQA
Copy link

SparkQA commented Feb 23, 2017

Test build #73332 has finished for PR 17036 at commit cad6379.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Feb 23, 2017

lgtm

@SparkQA
Copy link

SparkQA commented Feb 23, 2017

Test build #73337 has finished for PR 17036 at commit 9ff1e37.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 23, 2017

Test build #73359 has finished for PR 17036 at commit 468fc6d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

thanks for the review, merging to master!

@asfgit asfgit closed this in 4fa4cf1 Feb 23, 2017
Yunni pushed a commit to Yunni/spark that referenced this pull request Feb 27, 2017
## What changes were proposed in this pull request?

to be consistent with the scala API, we should also add `contains` to `Column` in pyspark.

## How was this patch tested?

updated unit test

Author: Wenchen Fan <[email protected]>

Closes apache#17036 from cloud-fan/pyspark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants