[SPARK-19650] Commands should not trigger a Spark job #17027
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #73279 has finished for PR 17027 at commit
|
|
Test build #73345 has finished for PR 17027 at commit
|
|
Test build #73350 has finished for PR 17027 at commit
|
hvanhovell
changed the title
|
Test build #73425 has finished for PR 17027 at commit
|
cloud-fan
reviewed
Feb 24, 2017
| // For various commands (like DDL) and queries with side effects, we force query execution | ||
| // to happen right away to let these side effects take place eagerly. | ||
| queryExecution.analyzed match { | ||
| // For various commands (like DDL) and queries with side effects, we force query execution |
Contributor
There was a problem hiding this comment.
actually let me remove it while merging
Contributor
|
LGTM |
Contributor
|
merging to master! |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
Spark executes SQL commands eagerly. It does this by creating an RDD which contains the command's results. The downside to this is that any action on this RDD triggers a Spark job which is expensive and is unnecessary. This PR fixes this by avoiding the materialization of an `RDD` for `Command`s; it just materializes the result and puts them in a `LocalRelation`. Added a regression test to `SQLQuerySuite`. Author: Herman van Hovell <[email protected]> Closes apache#17027 from hvanhovell/no-job-command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark executes SQL commands eagerly. It does this by creating an RDD which contains the command's results. The downside to this is that any action on this RDD triggers a Spark job which is expensive and is unnecessary.
This PR fixes this by avoiding the materialization of an
RDDforCommands; it just materializes the result and puts them in aLocalRelation.How was this patch tested?
Added a regression test to
SQLQuerySuite.