[SPARK-19679][ML] Destroy broadcasted object without blocking #17016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #73220 has finished for PR 17016 at commit
|
srowen
approved these changes
Feb 21, 2017
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Seems OK to me. These look like the only instances left in the code that don't set blocking=false. It's not worth changing the default at this point but I wonder when it would actually be useful to block, anyway
MLnick
approved these changes
Feb 21, 2017
Contributor
|
Merged to master |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
## What changes were proposed in this pull request?
Destroy broadcasted object without blocking
use `find mllib -name '*.scala' | xargs -i bash -c 'egrep "destroy" -n {} && echo {}'`
## How was this patch tested?
existing tests
Author: Zheng RuiFeng <[email protected]>
Closes apache#17016 from zhengruifeng/destroy_without_block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Destroy broadcasted object without blocking
use
find mllib -name '*.scala' | xargs -i bash -c 'egrep "destroy" -n {} && echo {}'How was this patch tested?
existing tests