[SPARK-19670] [SQL] [TEST] Enable Bucketed Table Reading and Writing Testing Without Hive Support #17004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #73180 has finished for PR 17004 at commit
|
Member
Author
tejasapatil
reviewed
Feb 21, 2017
| assume(spark.sparkContext.conf.get(CATALOG_IMPLEMENTATION) == "in-memory") | ||
| } | ||
|
|
||
| override protected def fileFormatsToTest: Seq[String] = Seq("parquet", "json") |
Contributor
There was a problem hiding this comment.
curious : why is orc not in this list ?
Member
Author
There was a problem hiding this comment.
orc is not available in sql/core package. : (
Contributor
|
LGTM with a minor nit |
Member
Author
|
retest this please |
|
Test build #73239 has finished for PR 17004 at commit
|
Member
Author
|
Thanks! Merging to master. |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
…sting Without Hive Support ### What changes were proposed in this pull request? Bucketed table reading and writing does not need Hive support. We can move the test cases from `sql/hive` to `sql/core`. After this PR, we can improve the test case coverage. Bucket table reading and writing can be tested with and without Hive support. ### How was this patch tested? N/A Author: Xiao Li <[email protected]> Closes apache#17004 from gatorsmile/mvTestCaseForBuckets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bucketed table reading and writing does not need Hive support. We can move the test cases from
sql/hivetosql/core. After this PR, we can improve the test case coverage. Bucket table reading and writing can be tested with and without Hive support.How was this patch tested?
N/A