-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-19639][SPARKR][Example]:Add spark.svmLinear example and update vignettes #16969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #73025 has finished for PR 16969 at commit
|
|
are we merging this after #16968? |
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't Linear go before Logistic?
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linear kernels?
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we actually don't have support for one-vs-the-rest strategy in R at the moment (existing JIRA or design still open), so perhaps it's best we don't reference that here
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it go with maxIter = 10 here too?
examples/src/main/r/ml/svmLinear.R
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linearSvc -> svmLinear? or Linear SVM?
|
Test build #73040 has finished for PR 16969 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few comments, and need to add back R section in ml programming guide and wait till the other PR is merged first
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels minor to me, but there was feedback that these section should be in the same order they are listed (ie sorted alphabetically)
examples/src/main/r/ml/svmLinear.R
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add sparkR.session.stop() at the end
864f2c3 to
648394f
Compare
|
Test build #73077 has finished for PR 16969 at commit
|
|
Test build #73072 has finished for PR 16969 at commit
|
|
I assume 2c3 is before you rebase. |
|
merged to master. I figure you could update the programming guide after the other PR is merged |
What changes were proposed in this pull request?
We recently add the spark.svmLinear API for SparkR. We need to add an example and update the vignettes.
How was this patch tested?
Manually run example.