Skip to content

[SPARK-19626][YARN]Using the correct config to set credentials update time #16955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 2 commits into from
Closed

[SPARK-19626][YARN]Using the correct config to set credentials update time #16955

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb0191
update cred using spark.yarn.credentials.updateTime
yaooqinn Feb 16, 2017
211bbd3
change remaining time calculation back
yaooqinn Feb 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ...anagers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,10 @@ private[spark] class CredentialUpdater(

/** Start the credential updater task */
def start(): Unit = {
val startTime = sparkConf.get(CREDENTIALS_RENEWAL_TIME)
val remainingTime = startTime - System.currentTimeMillis()
if (remainingTime <= 0) {
credentialUpdater.schedule(credentialUpdaterRunnable, 1, TimeUnit.MINUTES)
} else {
logInfo(s"Scheduling credentials refresh from HDFS in $remainingTime millis.")
credentialUpdater.schedule(credentialUpdaterRunnable, remainingTime, TimeUnit.MILLISECONDS)
}
val startTime = sparkConf.get(CREDENTIALS_UPDATE_TIME)
val remainingTime = Math.max(1, startTime - System.currentTimeMillis())
Copy link
Contributor

@jerryshao jerryshao Feb 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks different compared to the original code, also 1 is minute not millisecond.

Copy link
Member Author

@yaooqinn yaooqinn Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let me change it back

logInfo(s"Scheduling credentials refresh from HDFS in $remainingTime millis.")
credentialUpdater.schedule(credentialUpdaterRunnable, remainingTime, TimeUnit.MILLISECONDS)
}

private def updateCredentialsIfRequired(): Unit = {
Expand Down