[SPARK-19616][SparkR]:weightCol and aggregationDepth should be improved for some SparkR APIs #16945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #72965 has finished for PR 16945 at commit
|
Contributor
Author
|
cc @felixcheung |
Member
|
could you add some tests (I don't think we need one for each) that the weight col is set properly? |
Contributor
Author
|
I will add tests. Now I am looking for dataset other than iris to be used in the document. |
Contributor
Author
|
I add a test of weightCol for spark.logit. |
|
Test build #73043 has finished for PR 16945 at commit
|
Contributor
Author
|
@felixcheung I have made suggested changes. Thanks! |
Member
|
merged to master |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
…ed for some SparkR APIs ## What changes were proposed in this pull request? This is a follow-up PR of apache#16800 When doing SPARK-19456, we found that "" should be consider a NULL column name and should not be set. aggregationDepth should be exposed as an expert parameter. ## How was this patch tested? Existing tests. Author: [email protected] <[email protected]> Closes apache#16945 from wangmiao1981/svc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up PR of #16800
When doing SPARK-19456, we found that "" should be consider a NULL column name and should not be set. aggregationDepth should be exposed as an expert parameter.
How was this patch tested?
Existing tests.