Skip to content

Conversation

@chutium
Copy link
Contributor

@chutium chutium commented Jul 31, 2014

No description provided.

…ld be filtered out by sqlContext.parquetFile
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to reformat these lines a bit:

    val children = fs.listStatus(path).filterNot { status =>
      val name = status.getPath.getName
      name(0) == '.' || name == FileOutputCommitter.SUCCEEDED_FILE_NAME
    }

@liancheng
Copy link
Contributor

LGTM except for minor styling issue. Thanks!

@chutium
Copy link
Contributor Author

chutium commented Aug 1, 2014

done, thanks

@marmbrus
Copy link
Contributor

marmbrus commented Aug 8, 2014

add to whitelist

@SparkQA
Copy link

SparkQA commented Aug 8, 2014

QA tests have started for PR 1691. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18215/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 8, 2014

QA results for PR 1691:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18215/consoleFull

asfgit pushed a commit that referenced this pull request Aug 8, 2014
…ld be filtered out by sqlContext.parquetFile

Author: chutium <[email protected]>

Closes #1691 from chutium/SPARK-2700 and squashes the following commits:

b76ae8c [chutium] [SPARK-2700] [SQL] fixed styling issue
d75a8bd [chutium] [SPARK-2700] [SQL] Hidden files (such as .impala_insert_staging) should be filtered out by sqlContext.parquetFile

(cherry picked from commit b7c89a7)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in b7c89a7 Aug 8, 2014
@marmbrus
Copy link
Contributor

marmbrus commented Aug 8, 2014

Thanks! Merge into master and 1.1.

(Test failures look unrelated)

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
…ld be filtered out by sqlContext.parquetFile

Author: chutium <[email protected]>

Closes apache#1691 from chutium/SPARK-2700 and squashes the following commits:

b76ae8c [chutium] [SPARK-2700] [SQL] fixed styling issue
d75a8bd [chutium] [SPARK-2700] [SQL] Hidden files (such as .impala_insert_staging) should be filtered out by sqlContext.parquetFile
sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants