-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-2805] akka 2.3.4 #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-2805] akka 2.3.4 #1685
Conversation
|
Can one of the admins verify this patch? |
|
This is the bit that can't be committed now, right? is there a subset of the update that works with Scala 2.10 and 2.11 at the same time? that might be a good bit to break off first. |
|
On Thu, Jul 31, 2014 at 1:50 AM, Sean Owen [email protected] wrote:
I am breaking up the patches into as many separate PRs as possible, this is |
Signed-off-by: Anand Avati <[email protected]>
Not available in 2.3.x Signed-off-by: Anand Avati <[email protected]>
|
The latest updated patches depend on published packages built by https://github.com/avati/spark-shaded scripts |
|
This looks good to me, given automated tests pass. |
|
Jenkins, this is ok to test. |
|
I guess someone needs to publish the shaded jars first? |
|
Can one of the admins verify this patch? |
|
This is a critical patch for https://github.com/krasserm/akka-analytics/ |
|
@avati would you mind giving this a spin with the staged version of Akka? You'll need to add some remote repositories since we have several akka libraries we are working with: |
|
Jenkins, retest this please. |
|
LGTM, I have tested it locally by running test suits(only relevant ones.) @pwendell Can you trigger jenkins here and should be okay to merge ? |
|
Also, could you make the PR title a little more descriptive? Just use the description as the title. Since these are used for the final git commit, it's better to have less cryptic information there. |
|
Jenkins, testt his please. |
|
Jenkins, test this please. |
1 similar comment
|
Jenkins, test this please. |
|
QA tests have started for PR 1685 at commit
|
|
QA tests have finished for PR 1685 at commit
|
|
Test FAILed. |
|
This is failing because some zeromq content hasn't been published to maven central. I just published it so we'll give it some time and re-run. |
|
Jenkins, retest this please. |
|
QA tests have started for PR 1685 at commit
|
|
QA tests have finished for PR 1685 at commit
|
|
Test PASSed. |
|
Wow - I'm shocked this passed tests right away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avati is there a reason we disabled this test? I think we still want to support the Akka input stream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay @ScrapCodes is going to add a patch to fix this - I guess we were using some deprecated API's here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created an issue to track this. https://issues.apache.org/jira/browse/SPARK-3872
|
Great LGTM - thanks @avati for the help with this. |
Upgrade to akka 2.3.4