Skip to content

Conversation

@avati
Copy link
Contributor

@avati avati commented Jul 31, 2014

Upgrade to akka 2.3.4

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Jul 31, 2014

This is the bit that can't be committed now, right? is there a subset of the update that works with Scala 2.10 and 2.11 at the same time? that might be a good bit to break off first.

@avati
Copy link
Contributor Author

avati commented Jul 31, 2014

On Thu, Jul 31, 2014 at 1:50 AM, Sean Owen [email protected] wrote:

This is the bit that can't be committed now, right? is there a subset of
the update that works with Scala 2.10 and 2.11 at the same time? that might
be a good bit to break off first.

I am breaking up the patches into as many separate PRs as possible, this is
just one of them.

@avati avati changed the title [SPARK-1812] akka 2.3.4 [SPARK-2805] akka 2.3.4 Aug 2, 2014
@avati
Copy link
Contributor Author

avati commented Aug 6, 2014

The latest updated patches depend on published packages built by https://github.com/avati/spark-shaded scripts

@ScrapCodes
Copy link
Member

This looks good to me, given automated tests pass.

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

@avati
Copy link
Contributor Author

avati commented Aug 29, 2014

I guess someone needs to publish the shaded jars first?

@SparkQA
Copy link

SparkQA commented Sep 5, 2014

Can one of the admins verify this patch?

@rbraley
Copy link

rbraley commented Sep 10, 2014

This is a critical patch for https://github.com/krasserm/akka-analytics/

@pwendell
Copy link
Contributor

@avati would you mind giving this a spin with the staged version of Akka? You'll need to add some remote repositories since we have several akka libraries we are working with:

https://oss.sonatype.org/content/repositories/orgspark-project-1062
...
https://oss.sonatype.org/content/repositories/orgspark-project-1072

@ScrapCodes
Copy link
Member

Jenkins, retest this please.

@ScrapCodes
Copy link
Member

LGTM, I have tested it locally by running test suits(only relevant ones.) @pwendell Can you trigger jenkins here and should be okay to merge ?

@vanzin
Copy link
Contributor

vanzin commented Oct 6, 2014

Also, could you make the PR title a little more descriptive? Just use the description as the title. Since these are used for the final git commit, it's better to have less cryptic information there.

@pwendell
Copy link
Contributor

pwendell commented Oct 8, 2014

Jenkins, testt his please.

@pwendell
Copy link
Contributor

pwendell commented Oct 8, 2014

Jenkins, test this please.

1 similar comment
@pwendell
Copy link
Contributor

pwendell commented Oct 8, 2014

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have started for PR 1685 at commit 57a2315.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have finished for PR 1685 at commit 57a2315.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21430/Test FAILed.

@pwendell
Copy link
Contributor

pwendell commented Oct 8, 2014

This is failing because some zeromq content hasn't been published to maven central. I just published it so we'll give it some time and re-run.

@pwendell
Copy link
Contributor

pwendell commented Oct 8, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have started for PR 1685 at commit 57a2315.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have finished for PR 1685 at commit 57a2315.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21450/Test PASSed.

@pwendell
Copy link
Contributor

pwendell commented Oct 8, 2014

Wow - I'm shocked this passed tests right away.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avati is there a reason we disabled this test? I think we still want to support the Akka input stream.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay @ScrapCodes is going to add a patch to fix this - I guess we were using some deprecated API's here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created an issue to track this. https://issues.apache.org/jira/browse/SPARK-3872

@pwendell
Copy link
Contributor

pwendell commented Oct 9, 2014

Great LGTM - thanks @avati for the help with this.

@asfgit asfgit closed this in b9df8af Oct 9, 2014
sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants