[SPARK-19506][ML][PYTHON] Import warnings in pyspark.ml.util #16846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero323
changed the title
|
Test build #72546 has finished for PR 16846 at commit
|
Contributor
|
This looks good, normally I'd say we should have tests but since we are going to remove this in 2.2 that is probably ok as is. I'll merge this to master & the 2.1 branch if no one objects by EOD. |
Member
Author
|
@holdenk Sadly this part of the API is not tested directly and we depend on the indirect coverage. Maybe this is a sign should be tested. |
Member
Author
|
Thanks @holdenk |
Contributor
|
Merged into master & branch-2.1 , thanks @zero323 for catching & fixing this. |
asfgit
pushed a commit
that referenced
this pull request
Feb 13, 2017
## What changes were proposed in this pull request? Add missing `warnings` import. ## How was this patch tested? Manual tests. Author: zero323 <[email protected]> Closes #16846 from zero323/SPARK-19506. (cherry picked from commit 5e7cd33) Signed-off-by: Holden Karau <[email protected]>
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
## What changes were proposed in this pull request? Add missing `warnings` import. ## How was this patch tested? Manual tests. Author: zero323 <[email protected]> Closes apache#16846 from zero323/SPARK-19506.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add missing
warningsimport.How was this patch tested?
Manual tests.