[SPARK-19499][SS]Add more notes in the comments of Sink.addBatch() #16840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
reviewed
Feb 7, 2017
| * Otherwise, you may get a wrong result. | ||
| * | ||
| * Note 2: The method is supposed to be executed synchronously, i.e. the method should only return | ||
| * after data is added to sink successfully. |
Member
There was a problem hiding this comment.
nit: data is added -> data is consumed. add may be not clear as you can also add DataFrame to a collection and do nothing.
|
Test build #72527 has finished for PR 16840 at commit
|
|
Test build #72535 has finished for PR 16840 at commit
|
Member
|
LGTM. Thanks. Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Feb 8, 2017
## What changes were proposed in this pull request? addBatch method in Sink trait is supposed to be a synchronous method to coordinate with the fault-tolerance design in StreamingExecution (being different with the compute() method in DStream) We need to add more notes in the comments of this method to remind the developers ## How was this patch tested? existing tests Author: CodingCat <[email protected]> Closes #16840 from CodingCat/SPARK-19499. (cherry picked from commit d4cd975) Signed-off-by: Shixiong Zhu <[email protected]>
Contributor
Author
|
thanks |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
## What changes were proposed in this pull request? addBatch method in Sink trait is supposed to be a synchronous method to coordinate with the fault-tolerance design in StreamingExecution (being different with the compute() method in DStream) We need to add more notes in the comments of this method to remind the developers ## How was this patch tested? existing tests Author: CodingCat <[email protected]> Closes apache#16840 from CodingCat/SPARK-19499.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
addBatch method in Sink trait is supposed to be a synchronous method to coordinate with the fault-tolerance design in StreamingExecution (being different with the compute() method in DStream)
We need to add more notes in the comments of this method to remind the developers
How was this patch tested?
existing tests