[SPARK-19472][SQL] Parser should not mistake CASE WHEN(...) for a function call #16821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
changed the title
Member
|
+1 |
|
Test build #72454 has finished for PR 16821 at commit
|
Member
|
LGTM |
gatorsmile
reviewed
Feb 6, 2017
| assertEqual("case when a = 1 then b when a = 2 then c else d end", | ||
| CaseWhen(Seq(('a === 1, 'b.expr), ('a === 2, 'c.expr)), 'd)) | ||
| assertEqual("case when (1) + case when a > b then c else d end then f else g end", | ||
| CaseWhen(Seq((Literal(1) + CaseWhen(Seq(('a > 'b, 'c.expr)), 'd.expr), 'f.expr)), 'g)) |
Member
There was a problem hiding this comment.
To other reviewers: before the fix, if users do not put round brackets ( ), it works well. For example, case when 1 + case when a > b then c else d end then f else g end
asfgit
pushed a commit
that referenced
this pull request
Feb 6, 2017
…ction call ## What changes were proposed in this pull request? The SQL parser can mistake a `WHEN (...)` used in `CASE` for a function call. This happens in cases like the following: ```sql select case when (1) + case when 1 > 0 then 1 else 0 end = 2 then 1 else 0 end from tb ``` This PR fixes this by re-organizing the case related parsing rules. ## How was this patch tested? Added a regression test to the `ExpressionParserSuite`. Author: Herman van Hovell <[email protected]> Closes #16821 from hvanhovell/SPARK-19472. (cherry picked from commit cb2677b) Signed-off-by: gatorsmile <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Feb 6, 2017
…ction call ## What changes were proposed in this pull request? The SQL parser can mistake a `WHEN (...)` used in `CASE` for a function call. This happens in cases like the following: ```sql select case when (1) + case when 1 > 0 then 1 else 0 end = 2 then 1 else 0 end from tb ``` This PR fixes this by re-organizing the case related parsing rules. ## How was this patch tested? Added a regression test to the `ExpressionParserSuite`. Author: Herman van Hovell <[email protected]> Closes #16821 from hvanhovell/SPARK-19472. (cherry picked from commit cb2677b) Signed-off-by: gatorsmile <[email protected]>
Member
|
Thanks! Merging to master/2.1/2.0 |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
…ction call ## What changes were proposed in this pull request? The SQL parser can mistake a `WHEN (...)` used in `CASE` for a function call. This happens in cases like the following: ```sql select case when (1) + case when 1 > 0 then 1 else 0 end = 2 then 1 else 0 end from tb ``` This PR fixes this by re-organizing the case related parsing rules. ## How was this patch tested? Added a regression test to the `ExpressionParserSuite`. Author: Herman van Hovell <[email protected]> Closes apache#16821 from hvanhovell/SPARK-19472.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The SQL parser can mistake a
WHEN (...)used inCASEfor a function call. This happens in cases like the following:This PR fixes this by re-organizing the case related parsing rules.
How was this patch tested?
Added a regression test to the
ExpressionParserSuite.