[SPARK-14772][PYTHON][ML] Fixed Params.copy method to match Scala implementation #16772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ping @holdenk @jkbradley , please take a look when you get a chance - thanks! |
Contributor
|
Let me try and take a look tomorrow - I'm in transit today. |
|
Test build #72263 has finished for PR 16772 at commit
|
|
Test build #72270 has finished for PR 16772 at commit
|
BryanCutler
force-pushed
the
pyspark-ml-param_copy-Scala_sync-SPARK-14772
branch
from
c25c127 to
ce59d74
Compare
|
Test build #72271 has finished for PR 16772 at commit
|
Member
Author
|
ping @holdenk - mind taking a look? |
Member
|
LGTM @BryanCutler would you mind sending a backport PR against branch-2.1 to run Jenkins tests? Thank you! |
Member
|
well...will merge after new tests |
Member
|
jenkins test this please |
|
Test build #3581 has finished for PR 16772 at commit
|
Member
|
OK merging now. @BryanCutler do let me know if you don't have time to send a backport--thanks! |
|
Test build #73383 has finished for PR 16772 at commit
|
Member
Author
|
Thanks @jkbradley! I'll do a backport later tonight
On Feb 23, 2017 6:09 PM, "asfgit" <[email protected]> wrote:
Closed #16772 <#16772> via 2f69e3f
<2f69e3f>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16772 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AEUwdTNi511olIIv6OnLjBdjru4DCVyoks5rfjvAgaJpZM4L0hqD>
.
|
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
…lementation ## What changes were proposed in this pull request? Fixed the PySpark Params.copy method to behave like the Scala implementation. The main issue was that it did not account for the _defaultParamMap and merged it into the explicitly created param map. ## How was this patch tested? Added new unit test to verify the copy method behaves correctly for copying uid, explicitly created params, and default params. Author: Bryan Cutler <[email protected]> Closes apache#16772 from BryanCutler/pyspark-ml-param_copy-Scala_sync-SPARK-14772.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed the PySpark Params.copy method to behave like the Scala implementation. The main issue was that it did not account for the _defaultParamMap and merged it into the explicitly created param map.
How was this patch tested?
Added new unit test to verify the copy method behaves correctly for copying uid, explicitly created params, and default params.