Skip to content

[SPARK-18950][SQL] Report conflicting fields when merging two StructTypes #16365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiayue-zhang wants to merge 4 commits into from
Closed

[SPARK-18950][SQL] Report conflicting fields when merging two StructTypes #16365

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bc9f8a
[SPARK-18950][SQL] Report conflicting fields when merging two StructT…
jiayue-zhang Dec 20, 2016
54a898f
Add test for merge conflict message.
jiayue-zhang Jul 24, 2017
f500a11
JAVA try catch and test whole error message.
jiayue-zhang Jul 31, 2017
f4892c9
Fix scala style check
jiayue-zhang Jul 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
package org.apache.spark.sql.types

import scala.collection.mutable.ArrayBuffer
import scala.util.Try
import scala.util.{Failure, Success, Try}

import org.json4s.JsonDSL._

Expand Down Expand Up @@ -469,9 +469,16 @@ object StructType extends AbstractDataType {
case leftField @ StructField(leftName, leftType, leftNullable, _) =>
rightMapped.get(leftName)
.map { case rightField @ StructField(_, rightType, rightNullable, _) =>
leftField.copy(
dataType = merge(leftType, rightType),
nullable = leftNullable || rightNullable)
Try {

@gatorsmile gatorsmile Jul 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the JAVA style try and catch? See the https://github.com/databricks/scala-style-guide#exception-handling-try-vs-try

merge(leftType, rightType)
} match {
case Success(dataType) =>
leftField.copy(
dataType = dataType,
nullable = leftNullable || rightNullable)
case Failure(e) =>
throw new SparkException(s"Failed to merge field '$leftName': " + e.getMessage)

@gatorsmile gatorsmile Jul 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we throw an AnalysisException with both sides, left and right? Thanks!

@jiayue-zhang jiayue-zhang Jul 31, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other exceptions in this class are also SparkException, for example the precision conflicts. Should we keep it as SparkException?
For "with both sides, left and right", do you mean just to modify the message a bit to include both left and right names(though they are the same)?
@gatorsmile your other comments are resolved.

}
}
.orElse {
optionalMeta.putBoolean(metadataKeyForOptionalField, value = true)
Expand Down
11 changes: 7 additions & 4 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,17 @@ class DataTypeSuite extends SparkFunSuite {
test("merge where right contains type conflict") {
val left = StructType(
StructField("a", LongType) ::
StructField("b", FloatType) :: Nil)
StructField("conflictColumn", FloatType) :: Nil)

val right = StructType(
StructField("b", LongType) :: Nil)
StructField("conflictColumn", LongType) :: Nil)

intercept[SparkException] {
val message = intercept[SparkException] {
left.merge(right)
}
}.getMessage
assert(message.contains("conflictColumn"))

@gatorsmile gatorsmile Jul 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we capture the whole message? It can help us review the error message.

assert(message.contains(FloatType.toString))
assert(message.contains(LongType.toString))
}

test("existsRecursively") {
Expand Down