[SPARK-18690][PYTHON][SQL] Backward compatibility of unbounded frames #16123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to ensure backward compatibility
|
Test build #69585 has finished for PR 16123 at commit
|
|
Test build #69586 has finished for PR 16123 at commit
|
Contributor
|
Can you put a more descriptive title? |
zero323
changed the title
Member
Author
|
Sorry, long day. I was pretty sure I did. |
zero323
commented
Dec 2, 2016
| ).columns[0] | ||
|
|
||
| with patch("sys.maxsize", 2 ** 31 - 1): | ||
| importlib.reload(window) |
Member
Author
There was a problem hiding this comment.
This is something I don't like but it looks better than alternatives:
- Converting thresholds to methods so current
sys.maxsizeis picked up. - Mocking thresholds as well.
Contributor
|
Thanks - merging in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Dec 3, 2016
## What changes were proposed in this pull request? Makes `Window.unboundedPreceding` and `Window.unboundedFollowing` backward compatible. ## How was this patch tested? Pyspark SQL unittests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: zero323 <[email protected]> Closes #16123 from zero323/SPARK-17845-follow-up. (cherry picked from commit a9cbfc4) Signed-off-by: Reynold Xin <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
## What changes were proposed in this pull request? Makes `Window.unboundedPreceding` and `Window.unboundedFollowing` backward compatible. ## How was this patch tested? Pyspark SQL unittests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: zero323 <[email protected]> Closes apache#16123 from zero323/SPARK-17845-follow-up.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? Makes `Window.unboundedPreceding` and `Window.unboundedFollowing` backward compatible. ## How was this patch tested? Pyspark SQL unittests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: zero323 <[email protected]> Closes apache#16123 from zero323/SPARK-17845-follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Makes
Window.unboundedPrecedingandWindow.unboundedFollowingbackward compatible.How was this patch tested?
Pyspark SQL unittests.
Please review http://spark.apache.org/contributing.html before opening a pull request.