[SPARK-18497][SS]Make ForeachSink support watermark #15934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @marmbrus |
Contributor
|
LGTM |
|
Test build #68873 has finished for PR 15934 at commit
|
Contributor
|
Merging to master, 2.1. |
Contributor
|
Seems like this is a correctness bug as aggregation will give wrong results when using aggregations. This should ideally be fixed in 2.0 as well, independent of watermarks. |
asfgit
pushed a commit
that referenced
this pull request
Nov 19, 2016
## What changes were proposed in this pull request?
The issue in ForeachSink is the new created DataSet still uses the old QueryExecution. When `foreachPartition` is called, `QueryExecution.toString` will be called and then fail because it doesn't know how to plan EventTimeWatermark.
This PR just replaces the QueryExecution with IncrementalExecution to fix the issue.
## How was this patch tested?
`test("foreach with watermark")`.
Author: Shixiong Zhu <[email protected]>
Closes #15934 from zsxwing/SPARK-18497.
(cherry picked from commit 2a40de4)
Signed-off-by: Tathagata Das <[email protected]>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request?
The issue in ForeachSink is the new created DataSet still uses the old QueryExecution. When `foreachPartition` is called, `QueryExecution.toString` will be called and then fail because it doesn't know how to plan EventTimeWatermark.
This PR just replaces the QueryExecution with IncrementalExecution to fix the issue.
## How was this patch tested?
`test("foreach with watermark")`.
Author: Shixiong Zhu <[email protected]>
Closes apache#15934 from zsxwing/SPARK-18497.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The issue in ForeachSink is the new created DataSet still uses the old QueryExecution. When
foreachPartitionis called,QueryExecution.toStringwill be called and then fail because it doesn't know how to plan EventTimeWatermark.This PR just replaces the QueryExecution with IncrementalExecution to fix the issue.
How was this patch tested?
test("foreach with watermark").