[SPARK-18445][BUILD][DOCS] Fix the markdown for `Note:`/`NOTE:`/`Note that`/`'''Note:'''` across Scala/Java API documentation #15889

HyukjinKwon · 2016-11-15T11:16:34Z

What changes were proposed in this pull request?

It seems in Scala/Java,

Note:
NOTE:
Note that
'''Note:'''
@note

This PR proposes to fix those to @note to be consistent.

Before

Scala
Java

After

Scala
Java

How was this patch tested?

The notes were found via

grep -r "NOTE: " . | \ # Note:|NOTE:|Note that|'''Note:'''
grep -v "// NOTE: " | \  # starting with // does not appear in API documentation.
grep -E '.scala|.java' | \ # java/scala files
grep -v Suite | \ # exclude tests
grep -v Test | \ # exclude tests
grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation
-e 'org.apache.spark.api.java.function' \ # note that this is a regular expression. So actual matches were mostly `org/apache/spark/api/java/functions ...`
-e 'org.apache.spark.api.r' \
...

grep -r "Note that " . | \ # Note:|NOTE:|Note that|'''Note:'''
grep -v "// Note that " | \  # starting with // does not appear in API documentation.
grep -E '.scala|.java' | \ # java/scala files
grep -v Suite | \ # exclude tests
grep -v Test | \ # exclude tests
grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation
-e 'org.apache.spark.api.java.function' \
-e 'org.apache.spark.api.r' \
...

grep -r "Note: " . | \ # Note:|NOTE:|Note that|'''Note:'''
grep -v "// Note: " | \  # starting with // does not appear in API documentation.
grep -E '.scala|.java' | \ # java/scala files
grep -v Suite | \ # exclude tests
grep -v Test | \ # exclude tests
grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation
-e 'org.apache.spark.api.java.function' \
-e 'org.apache.spark.api.r' \
...

grep -r "'''Note:'''" . | \ # Note:|NOTE:|Note that|'''Note:'''
grep -v "// '''Note:''' " | \  # starting with // does not appear in API documentation.
grep -E '.scala|.java' | \ # java/scala files
grep -v Suite | \ # exclude tests
grep -v Test | \ # exclude tests
grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation
-e 'org.apache.spark.api.java.function' \
-e 'org.apache.spark.api.r' \
...

And then fixed one by one comparing with API documentation/access modifiers.

After that, manually tested via jekyll build.

HyukjinKwon · 2016-11-15T11:17:01Z

I am going to, double check any missed one first, and then sweep them again and again by leaving comments with images from the built API doc each by each change to double-check.

SparkQA · 2016-11-15T11:19:02Z

Test build #68660 has finished for PR 15889 at commit 2acb56f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2016-11-15T11:37:59Z

Hi @sandeepmreddy, thanks for approving but actually it is WIP. It would be great if it is reviewed when it's complete.

SparkQA · 2016-11-16T16:24:27Z

Test build #68721 has finished for PR 15889 at commit 30794b4.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-11-16T18:50:03Z

Test build #68723 has finished for PR 15889 at commit b5fd61e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-11-16T20:53:07Z

Test build #68727 has finished for PR 15889 at commit 436fabf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2016-11-16T20:54:26Z

@HyukjinKwon this is ready to go right?

HyukjinKwon · 2016-11-16T23:04:55Z

Ah, I couldn't check all of the java documentation yet because I have some problems with javadoc8 because of several errors (although they look already existing ones). So, I am thinking of trying to use different version. (Maybe I am doing something wrong assuming it is not mentioned in docs/README.md).

Will check several times more the built documentation and also update PR description within today.I am also fine if you are worried of conflicts from merging others. I can resolve them.

SparkQA · 2016-11-17T07:17:32Z

Test build #68756 has started for PR 15889 at commit f2b201c.

HyukjinKwon

It seems @note plays fine with existing formats.

HyukjinKwon · 2016-11-17T09:32:08Z

core/src/main/scala/org/apache/spark/Partitioner.scala

Before

Scala

Java

After

Scala

Java

HyukjinKwon · 2016-11-17T09:37:48Z

core/src/main/scala/org/apache/spark/SparkContext.scala

Before

Scala

Java

After

Scala

Java

HyukjinKwon · 2016-11-17T09:41:54Z

project/SparkBuild.scala

@srowen, this was added to deal with @note annotation in Java documentation. It seems @note for scaladoc not for javadoc. So, I had to manually deal with this.

HyukjinKwon · 2016-11-17T09:42:25Z

pom.xml

Here is the equivalent one with SparkBuild.scala.

SparkQA · 2016-11-17T11:28:51Z

Test build #68761 has finished for PR 15889 at commit d22136e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2016-11-17T11:59:44Z

(it was simply rebased and added (in 39873dc) 5 instances introduced in another PR)

HyukjinKwon · 2016-11-17T12:05:57Z

sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala

   *
+   * @note This is NOT guaranteed to provide exactly the fraction of the count
+   * of the given [[Dataset]].
+   *


Scala

Java

HyukjinKwon · 2016-11-17T12:06:45Z

Thank you for approving Sean!

SparkQA · 2016-11-17T14:08:11Z

Test build #68775 has finished for PR 15889 at commit 8cd3cdd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2016-11-17T14:12:04Z

retest this please

SparkQA · 2016-11-17T16:57:42Z

Test build #68783 has finished for PR 15889 at commit 8cd3cdd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-11-17T17:08:58Z

Test build #68785 has finished for PR 15889 at commit 8cd3cdd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen

A few last questions now that I skimmed it again, actually

srowen · 2016-11-17T19:47:17Z

core/src/main/scala/org/apache/spark/api/java/JavaPairRDD.scala

-   * "combined type" C. Note that V and C can be different -- for example, one might group an
+   * "combined type" C.
+   *
+   * @note V and C can be different -- for example, one might group an


I was skimming the changes again and noticed this. This causes this note to render pretty separately from this text, but it seems to belong with the sentence above.

Does it cause the bullet points below to be in the note? because they also seem unrelated to this 'note'.

Could be OK but wasn't sure whether this was really a stand-alone note as much as a usage of the word "note"

Oh, yes. It seems so. Will check the same instances again. Thank you.

srowen · 2016-11-17T19:48:51Z

core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala

   * supporting the key and value types K and V in this RDD.
   *
-   * Note that, we should make sure our tasks are idempotent when speculation is enabled, i.e. do
+   * @note We should make sure our tasks are idempotent when speculation is enabled, i.e. do


Likewise I wonder if these following sentences all go into the note? they go together.

Ah, I left and removed an useless comment. Yes, it seems it goes together.

It almost looks like it should be a code comment, not scaladoc. Well, I don't feel strongly about changing it if it was already in the scaladoc.

srowen · 2016-11-17T19:52:45Z

streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala

   * it will process either one or all of the RDDs returned by the queue.
   *
-   * NOTE:
+   * @note


Likewise here just want to make sure that this actually causes the following 3 lines are in the note?

Yup, it seems keeping the original format at least.

Before

Scala

Java

After

Scala

Java

SparkQA · 2016-11-18T05:37:36Z

Test build #68828 has started for PR 15889 at commit 1ef229a.

HyukjinKwon · 2016-11-18T07:48:43Z

core/src/main/scala/org/apache/spark/api/java/JavaPairRDD.scala

   * items with the same key).
+   *
+   * @note V and C can be different -- for example, one might group a RDD of type (Int, Int) into
+   * an RDD of type (Int, List[Int]).


It seems fine now.

OK, it works alright as a standalone note. It could have stayed an inline sentence too. OK either way.

srowen · 2016-11-18T10:35:09Z

mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala

   *
-   * @note Vectors to be transformed must be the same length
-   * as the source vectors given to [[PCA.fit()]].
+   * @note Vectors to be transformed must be the same lengtt as the source vectors given


Heh sorry @HyukjinKwon but there's now a typo here: lengtt

Doh! I will check the same instances. I am so sorry.

SparkQA · 2016-11-18T11:09:19Z

Test build #68839 has finished for PR 15889 at commit b61ab72.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-11-18T13:49:48Z

Test build #68850 has finished for PR 15889 at commit 826c950.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2016-11-18T13:53:38Z

core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala

   * In addition, users can control the partitioning of the output RDD, and whether to perform
   * map-side aggregation (if a mapper can produce multiple items with the same key).
+   *
+   * @note V and C can be different -- for example, one might group a RDD of type


"an RDD" is correct actually. Could you make this one last fix by reverting just that change? I bet there are occurrences of "a RDD" in the docs elsewhere and you're welcome to fix them too if it makes it easier to search and replace it.

Ah... I see. Sure. I thought "a RDD" is correct but just realised it after googling it.. Will fix and replace. I see. It should be an

SparkQA · 2016-11-18T18:43:31Z

Test build #68859 has finished for PR 15889 at commit 4576f7d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-11-18T18:44:44Z

Test build #68861 has finished for PR 15889 at commit ee5b035.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

… that`/`'''Note:'''` across Scala/Java API documentation It seems in Scala/Java, - `Note:` - `NOTE:` - `Note that` - `'''Note:'''` - `note` This PR proposes to fix those to `note` to be consistent. **Before** - Scala ![2016-11-17 6 16 39](https://cloud.githubusercontent.com/assets/6477701/20383180/1a7aed8c-acf2-11e6-9611-5eaf6d52c2e0.png) - Java ![2016-11-17 6 14 41](https://cloud.githubusercontent.com/assets/6477701/20383096/c8ffc680-acf1-11e6-914a-33460bf1401d.png) **After** - Scala ![2016-11-17 6 16 44](https://cloud.githubusercontent.com/assets/6477701/20383167/09940490-acf2-11e6-937a-0d5e1dc2cadf.png) - Java ![2016-11-17 6 13 39](https://cloud.githubusercontent.com/assets/6477701/20383132/e7c2a57e-acf1-11e6-9c47-b849674d4d88.png) The notes were found via ```bash grep -r "NOTE: " . | \ # Note:|NOTE:|Note that|'''Note:''' grep -v "// NOTE: " | \ # starting with // does not appear in API documentation. grep -E '.scala|.java' | \ # java/scala files grep -v Suite | \ # exclude tests grep -v Test | \ # exclude tests grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation -e 'org.apache.spark.api.java.function' \ # note that this is a regular expression. So actual matches were mostly `org/apache/spark/api/java/functions ...` -e 'org.apache.spark.api.r' \ ... ``` ```bash grep -r "Note that " . | \ # Note:|NOTE:|Note that|'''Note:''' grep -v "// Note that " | \ # starting with // does not appear in API documentation. grep -E '.scala|.java' | \ # java/scala files grep -v Suite | \ # exclude tests grep -v Test | \ # exclude tests grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation -e 'org.apache.spark.api.java.function' \ -e 'org.apache.spark.api.r' \ ... ``` ```bash grep -r "Note: " . | \ # Note:|NOTE:|Note that|'''Note:''' grep -v "// Note: " | \ # starting with // does not appear in API documentation. grep -E '.scala|.java' | \ # java/scala files grep -v Suite | \ # exclude tests grep -v Test | \ # exclude tests grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation -e 'org.apache.spark.api.java.function' \ -e 'org.apache.spark.api.r' \ ... ``` ```bash grep -r "'''Note:'''" . | \ # Note:|NOTE:|Note that|'''Note:''' grep -v "// '''Note:''' " | \ # starting with // does not appear in API documentation. grep -E '.scala|.java' | \ # java/scala files grep -v Suite | \ # exclude tests grep -v Test | \ # exclude tests grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation -e 'org.apache.spark.api.java.function' \ -e 'org.apache.spark.api.r' \ ... ``` And then fixed one by one comparing with API documentation/access modifiers. After that, manually tested via `jekyll build`. Author: hyukjinkwon <[email protected]> Closes #15889 from HyukjinKwon/SPARK-18437. (cherry picked from commit d5b1d5f) Signed-off-by: Sean Owen <[email protected]>

srowen · 2016-11-19T11:25:37Z

Merged to master/2.1

HyukjinKwon · 2016-11-19T11:29:45Z

Thank you!!

jiangxb1987 · 2016-11-19T15:31:09Z

core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala

  }

-  /** Write a RDD partition out in a single Spark task. */
+  /** Write an RDD partition out in a single Spark task. */


Why are you changing this?

Because a RDD was incorrect in English.

Am I missing something? I'm not familiar with English grammer, but shouldn't we use a when the RDD start with R?

I searched the code base and there are both a RDD and an RDD.

We should replace them to an RDD.

I think on my Mac I found and replaced them by

find . -type f -name "*.scala" | xargs sed -i '' 's/ A RDD / An RDD /g' find . -type f -name "*.scala" | xargs sed -i '' 's/ A RDD\./ An RDD\./g' find . -type f -name "*.scala" | xargs sed -i '' 's/ a RDD / an RDD /g' find . -type f -name "*.scala" | xargs sed -i '' 's/ a RDD\./ an RDD\./g' find . -type f -name "*.java" | xargs sed -i '' 's/ A RDD / An RDD /g' find . -type f -name "*.java" | xargs sed -i '' 's/ A RDD\./ An RDD\./g' find . -type f -name "*.java" | xargs sed -i '' 's/ a RDD / an RDD /g' find . -type f -name "*.java" | xargs sed -i '' 's/ a RDD\./ an RDD\./g' find . -type f -name "*.r" | xargs sed -i '' 's/ A RDD / An RDD /g' find . -type f -name "*.r" | xargs sed -i '' 's/ A RDD\./ An RDD\./g' find . -type f -name "*.r" | xargs sed -i '' 's/ a RDD / an RDD /g' find . -type f -name "*.r" | xargs sed -i '' 's/ a RDD\./ an RDD\./g' find . -type f -name "*.py" | xargs sed -i '' 's/ A RDD / An RDD /g' find . -type f -name "*.py" | xargs sed -i '' 's/ A RDD\./ An RDD\./g' find . -type f -name "*.py" | xargs sed -i '' 's/ a RDD / an RDD /g' find . -type f -name "*.py" | xargs sed -i '' 's/ a RDD\./ an RDD\./g' find . -type f -name "*.md" | xargs sed -i '' 's/ A RDD / An RDD /g' find . -type f -name "*.md" | xargs sed -i '' 's/ A RDD\./ An RDD\./g' find . -type f -name "*.md" | xargs sed -i '' 's/ a RDD / an RDD /g' find . -type f -name "*.md" | xargs sed -i '' 's/ a RDD\./ an RDD\./g'

If there are more, we should fix. Actually, i was preparing a minor PR to fix all of them including the same instances such as a X.. to an X...

BTW, I also made this mistake and found actually an RDD is correct after googling :).

Could you point where a RDD is? I will try to include them in a similar way above.

Yes, "an RDD" is correct because "a" precedes consonant sounds and "an" precedes vowel sounds. So it's "an arr-dee-dee".

We don't need to fix up every last instance of this. It was a good idea to fix it all while fixing some that overlapped with this PR though.

Ah, I will include

./R/pkg/inst/tests/testthat/test_sparkSQL.R:test_that("jsonRDD() on a RDD with json string", { ./R/pkg/R/RDD.R:#' @param x A RDD.

It seems I should have used -name "*.R" instead.

I see. Sure, let me just keep it and will leave some comments in the related PRs in the future if possible.

… that`/`'''Note:'''` across Scala/Java API documentation ## What changes were proposed in this pull request? It seems in Scala/Java, - `Note:` - `NOTE:` - `Note that` - `'''Note:'''` - `note` This PR proposes to fix those to `note` to be consistent. **Before** - Scala ![2016-11-17 6 16 39](https://cloud.githubusercontent.com/assets/6477701/20383180/1a7aed8c-acf2-11e6-9611-5eaf6d52c2e0.png) - Java ![2016-11-17 6 14 41](https://cloud.githubusercontent.com/assets/6477701/20383096/c8ffc680-acf1-11e6-914a-33460bf1401d.png) **After** - Scala ![2016-11-17 6 16 44](https://cloud.githubusercontent.com/assets/6477701/20383167/09940490-acf2-11e6-937a-0d5e1dc2cadf.png) - Java ![2016-11-17 6 13 39](https://cloud.githubusercontent.com/assets/6477701/20383132/e7c2a57e-acf1-11e6-9c47-b849674d4d88.png) ## How was this patch tested? The notes were found via ```bash grep -r "NOTE: " . | \ # Note:|NOTE:|Note that|'''Note:''' grep -v "// NOTE: " | \ # starting with // does not appear in API documentation. grep -E '.scala|.java' | \ # java/scala files grep -v Suite | \ # exclude tests grep -v Test | \ # exclude tests grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation -e 'org.apache.spark.api.java.function' \ # note that this is a regular expression. So actual matches were mostly `org/apache/spark/api/java/functions ...` -e 'org.apache.spark.api.r' \ ... ``` ```bash grep -r "Note that " . | \ # Note:|NOTE:|Note that|'''Note:''' grep -v "// Note that " | \ # starting with // does not appear in API documentation. grep -E '.scala|.java' | \ # java/scala files grep -v Suite | \ # exclude tests grep -v Test | \ # exclude tests grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation -e 'org.apache.spark.api.java.function' \ -e 'org.apache.spark.api.r' \ ... ``` ```bash grep -r "Note: " . | \ # Note:|NOTE:|Note that|'''Note:''' grep -v "// Note: " | \ # starting with // does not appear in API documentation. grep -E '.scala|.java' | \ # java/scala files grep -v Suite | \ # exclude tests grep -v Test | \ # exclude tests grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation -e 'org.apache.spark.api.java.function' \ -e 'org.apache.spark.api.r' \ ... ``` ```bash grep -r "'''Note:'''" . | \ # Note:|NOTE:|Note that|'''Note:''' grep -v "// '''Note:''' " | \ # starting with // does not appear in API documentation. grep -E '.scala|.java' | \ # java/scala files grep -v Suite | \ # exclude tests grep -v Test | \ # exclude tests grep -e 'org.apache.spark.api.java' \ # packages appear in API documenation -e 'org.apache.spark.api.java.function' \ -e 'org.apache.spark.api.r' \ ... ``` And then fixed one by one comparing with API documentation/access modifiers. After that, manually tested via `jekyll build`. Author: hyukjinkwon <[email protected]> Closes apache#15889 from HyukjinKwon/SPARK-18437.

sandeepmreddy approved these changes Nov 15, 2016

View reviewed changes

HyukjinKwon changed the title ~~[WIP][SPARK-18445][DOCS] Fix the markdown for Note:/NOTE:/Note that across Scala/Java API documentation~~ [WIP][SPARK-18445][DOCS] Fix the markdown for Note:/NOTE:/Note that/'''Note:''' across Scala/Java API documentation Nov 16, 2016

HyukjinKwon commented Nov 17, 2016

View reviewed changes

HyukjinKwon changed the title ~~[WIP][SPARK-18445][DOCS] Fix the markdown for Note:/NOTE:/Note that/'''Note:''' across Scala/Java API documentation~~ [SPARK-18445][DOCS] Fix the markdown for Note:/NOTE:/Note that/'''Note:''' across Scala/Java API documentation Nov 17, 2016

HyukjinKwon commented Nov 17, 2016

View reviewed changes

pom.xml Outdated

Copy link

Member Author

HyukjinKwon Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the equivalent one with SparkBuild.scala.

HyukjinKwon changed the title ~~[SPARK-18445][DOCS] Fix the markdown for Note:/NOTE:/Note that/'''Note:''' across Scala/Java API documentation~~ [SPARK-18445][BUILD][DOCS] Fix the markdown for Note:/NOTE:/Note that/'''Note:''' across Scala/Java API documentation Nov 17, 2016

srowen approved these changes Nov 17, 2016

View reviewed changes

HyukjinKwon added 10 commits November 17, 2016 20:45

Clean up Note: to '''Note:'''

4911123

Clean up NOTE: to '''Note:'''

382aec0

Clean up Note that to '''Note:'''

8b9f1bd

Fix Java ones too

bee0f7f

Double-check and find more

f32e781

Use @name

12105b7

Fix pom.xml and SparkBuild.scala to allow note annotation in javadoc

b6a69fa

Clean up and verify Java/Scala API documentation

02a90e2

Fix minor typos and consistency

fad2143

Fix Note: introduced from another PR

39873dc

HyukjinKwon force-pushed the SPARK-18437 branch from d22136e to 39873dc Compare November 17, 2016 11:58

HyukjinKwon commented Nov 17, 2016

View reviewed changes

srowen reviewed Nov 17, 2016

View reviewed changes

Fix more typoes and double check note's contents

1ef229a

HyukjinKwon commented Nov 18, 2016

View reviewed changes

Minor indentation cleanup

b61ab72

srowen reviewed Nov 18, 2016

View reviewed changes

HyukjinKwon added 2 commits November 18, 2016 19:44

Fix a typo

7106984

Fix more typos and indentation

826c950

srowen reviewed Nov 18, 2016

View reviewed changes

Fix a RDD/A RDD to an RDD/An RDD

ee5b035

HyukjinKwon force-pushed the SPARK-18437 branch from 4576f7d to ee5b035 Compare November 18, 2016 16:15

asfgit closed this in d5b1d5f Nov 19, 2016

jiangxb1987 reviewed Nov 19, 2016

View reviewed changes

aditya1702 mentioned this pull request Nov 19, 2016

[SPARK-18447][BUILD][DOCS]Fix Note:/NOTE:/Note that across Pyth… #15940

Closed

HyukjinKwon deleted the SPARK-18437 branch January 2, 2018 03:39

[SPARK-18445][BUILD][DOCS] Fix the markdown for Note:/NOTE:/Note that/'''Note:''' across Scala/Java API documentation #15889

[SPARK-18445][BUILD][DOCS] Fix the markdown for Note:/NOTE:/Note that/'''Note:''' across Scala/Java API documentation #15889

Uh oh!

Conversation

HyukjinKwon commented Nov 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

HyukjinKwon commented Nov 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SparkQA commented Nov 15, 2016

Uh oh!

HyukjinKwon commented Nov 15, 2016

Uh oh!

SparkQA commented Nov 16, 2016

Uh oh!

SparkQA commented Nov 16, 2016

Uh oh!

SparkQA commented Nov 16, 2016

Uh oh!

srowen commented Nov 16, 2016

Uh oh!

HyukjinKwon commented Nov 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SparkQA commented Nov 17, 2016

Uh oh!

HyukjinKwon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Nov 17, 2016

Uh oh!

HyukjinKwon commented Nov 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HyukjinKwon commented Nov 17, 2016

Uh oh!

SparkQA commented Nov 17, 2016

Uh oh!

HyukjinKwon commented Nov 17, 2016

Uh oh!

SparkQA commented Nov 17, 2016

Uh oh!

SparkQA commented Nov 17, 2016

Uh oh!

srowen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HyukjinKwon Nov 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HyukjinKwon Nov 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Nov 18, 2016

Uh oh!

[SPARK-18445][BUILD][DOCS] Fix the markdown for `Note:`/`NOTE:`/`Note that`/`'''Note:'''` across Scala/Java API documentation #15889

[SPARK-18445][BUILD][DOCS] Fix the markdown for `Note:`/`NOTE:`/`Note that`/`'''Note:'''` across Scala/Java API documentation #15889

HyukjinKwon commented Nov 15, 2016 •

edited

Loading

HyukjinKwon commented Nov 15, 2016 •

edited

Loading

HyukjinKwon commented Nov 16, 2016 •

edited

Loading

HyukjinKwon commented Nov 17, 2016 •

edited

Loading

HyukjinKwon Nov 18, 2016 •

edited

Loading

HyukjinKwon Nov 18, 2016 •

edited

Loading

HyukjinKwon Nov 19, 2016 •

edited

Loading

HyukjinKwon Nov 19, 2016 •

edited

Loading