[SPARK-18268][ML][MLLib] ALS fail with better message if ratings is empty rdd #15809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALS.train and ALS.trainImplicit are also affected
Member
|
What about putting this check in A tiny unit test wouldn't hurt. |
|
Test build #68342 has finished for PR 15809 at commit
|
techaddict
changed the title
|
Test build #68347 has finished for PR 15809 at commit
|
techaddict
changed the title
techaddict
changed the title
Contributor
|
LGTM |
|
@srowen What about the python code? this was for scala only right? |
Member
|
Python API calls the Scala API so I think this is sufficient. |
|
@srowen Ok. Thanks 👍 |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…mpty rdd ## What changes were proposed in this pull request? ALS.run fail with better message if ratings is empty rdd ALS.train and ALS.trainImplicit are also affected ## How was this patch tested? added new tests Author: Sandeep Singh <[email protected]> Closes apache#15809 from techaddict/SPARK-18268.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ALS.run fail with better message if ratings is empty rdd
ALS.train and ALS.trainImplicit are also affected
How was this patch tested?
added new tests