Skip to content

[SPARK-18169][SQL] Suppress warnings when dropping views on a dropped table #15682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-18169][SQL] Suppress warnings when dropping views on a dropped table #15682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ case class DropTableCommand(
sparkSession.sharedState.cacheManager.uncacheQuery(
sparkSession.table(tableName.quotedString))
} catch {
case ae: AnalysisException if ae.getMessage.contains("Table or view not found") =>
Copy link
Member

@gatorsmile gatorsmile Nov 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it NoSuchTableException?

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Nov 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review, @gatorsmile .
It's originally NoSuchTableException, but Analyzer changed into this at here.
So, the catch expression becomes ugly.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Nov 16, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I fix that to throw the original exception? NoSuchTableException extends AnalysisException and has more context like database name. Oops, Sorry. We cannot. The current AnalysisException has the line number and start position.

case NonFatal(e) => log.warn(e.toString, e)
}
catalog.refreshTable(tableName)
Expand Down