[SPARK-18121][SQL] Unable to query global temp views when hive support is enabled #15649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
Member
|
@cloud-fan Could you take a look at this? The code changes look good to me. Thanks! |
Member
|
LGTM |
cloud-fan
reviewed
Oct 27, 2016
| test("query global temp view") { | ||
| val df = Seq(1).toDF("i1") | ||
| df.createGlobalTempView("tbl1") | ||
| checkAnswer(spark.sql("select * from global_temp.tbl1"), Row(1)) |
Contributor
There was a problem hiding this comment.
instead of hardcode global_temp here, we should read the conf: spark.sharedState.globalTempViewManager.database
Contributor
Author
There was a problem hiding this comment.
Thanks @cloud-fan. I have changed the test to get the global_temp db from the conf. spark.conf.get("spark.sql.globalTempDatabase”)
It looks like there are two ways to get it:
- One is using the conf
- Accessing the spark.sharedState.globalTempViewManager.database
In the test, I am now getting it from the conf. Please see if this is ok. Thanks.
Contributor
|
ok to test |
Contributor
|
LGTM |
|
Test build #67621 has finished for PR 15649 at commit
|
Member
|
retest this please |
|
Test build #67627 has finished for PR 15649 at commit
|
|
Test build #67657 has finished for PR 15649 at commit
|
Contributor
|
thanks, merging to master! |
Contributor
Author
|
Thanks @cloud-fan, @gatorsmile, @viirya |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
…t is enabled ## What changes were proposed in this pull request? Issue: Querying on a global temp view throws Table or view not found exception. Fix: Update the lookupRelation in HiveSessionCatalog to check for global temp views similar to the SessionCatalog.lookupRelation. Before fix: Querying on a global temp view ( for. e.g.: select * from global_temp.v1) throws Table or view not found exception After fix: Query succeeds and returns the right result. ## How was this patch tested? - Two unit tests are added to check for global temp view for the code path when hive support is enabled. - Regression unit tests were run successfully. ( build/sbt -Phive hive/test, build/sbt sql/test, build/sbt catalyst/test) Author: Sunitha Kambhampati <[email protected]> Closes apache#15649 from skambha/lookuprelationChanges.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…t is enabled ## What changes were proposed in this pull request? Issue: Querying on a global temp view throws Table or view not found exception. Fix: Update the lookupRelation in HiveSessionCatalog to check for global temp views similar to the SessionCatalog.lookupRelation. Before fix: Querying on a global temp view ( for. e.g.: select * from global_temp.v1) throws Table or view not found exception After fix: Query succeeds and returns the right result. ## How was this patch tested? - Two unit tests are added to check for global temp view for the code path when hive support is enabled. - Regression unit tests were run successfully. ( build/sbt -Phive hive/test, build/sbt sql/test, build/sbt catalyst/test) Author: Sunitha Kambhampati <[email protected]> Closes apache#15649 from skambha/lookuprelationChanges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Issue:
Querying on a global temp view throws Table or view not found exception.
Fix:
Update the lookupRelation in HiveSessionCatalog to check for global temp views similar to the SessionCatalog.lookupRelation.
Before fix:
Querying on a global temp view ( for. e.g.: select * from global_temp.v1) throws Table or view not found exception
After fix:
Query succeeds and returns the right result.
How was this patch tested?