[SPARK-18109][ML] Add instrumentation to GMM #15636
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #67549 has finished for PR 15636 at commit
|
Contributor
Author
|
@jkbradley @yanboliang Could you please make a review in your spare time? |
jkbradley
reviewed
Oct 27, 2016
Member
There was a problem hiding this comment.
It would be good to log numFeatures at this point (since it's readily available from the model).
Contributor
Author
There was a problem hiding this comment.
OK, I will add numFeatures here.
Member
|
Other than that, this looks fine. |
zhengruifeng
force-pushed
the
gmm_instr
branch
from
069f377 to
e9736ff
Compare
|
Test build #67687 has finished for PR 15636 at commit
|
Contributor
|
LGTM, merged into master. Thanks! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? Add instrumentation to GMM ## How was this patch tested? Test in spark-shell Author: Zheng RuiFeng <[email protected]> Closes apache#15636 from zhengruifeng/gmm_instr.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? Add instrumentation to GMM ## How was this patch tested? Test in spark-shell Author: Zheng RuiFeng <[email protected]> Closes apache#15636 from zhengruifeng/gmm_instr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add instrumentation to GMM
How was this patch tested?
Test in spark-shell