[HOTFIX] Fix broken build from SPARK-17894 #15617
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. The compile is successful. I'm going to merge it. Thanks! |
|
Test build #67481 has finished for PR 15617 at commit
|
Contributor
Author
|
Thanks @zsxwing -- sorry about this! Looks like the test failure was unrelated. |
Member
|
@kayousterhout no problem. yeah, the failure is unrelated. |
Member
|
Thanks @kayousterhout and @zsxwing for the support. I have missed to build with v2.10 and will help as a good experience for incoming PRs ;) |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
The named parameter in an overridden class isn't supported in Scala 2.10 so was breaking the build. cc zsxwing Author: Kay Ousterhout <[email protected]> Closes apache#15617 from kayousterhout/hotfix.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
The named parameter in an overridden class isn't supported in Scala 2.10 so was breaking the build. cc zsxwing Author: Kay Ousterhout <[email protected]> Closes apache#15617 from kayousterhout/hotfix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The named parameter in an overridden class isn't supported in Scala 2.10 so was breaking the build.
cc @zsxwing