[SPARK-18204][WEBUI] Remove SparkUI.appUIAddress #15603
Conversation
|
Test build #67420 has finished for PR 15603 at commit
|
|
The build has just proved that my thinking was correct. I think I'll propose few other (more agressive) changes to clean the code up a little bit more. I'd appreciate any comments (or acceptance). |
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Some of this, I wouldn't change randomly for its own sake. Removing the bit of dead code is reasonable if you take it a step further.
There was a problem hiding this comment.
I think these two methods can just be eliminated, because appUIAddress does seem to return exactly the same thing, and appUIHostPort is only referenced from tests.
There was a problem hiding this comment.
Thanks Sean for confirming my thoughts! That's exactly the feedback I expected to get from you (or other Spark committers).
There was a problem hiding this comment.
This can just be removed then, because this becomes a no-op. And then getAppName in the superclass can be removed. It's a pointless getter.
There was a problem hiding this comment.
Yes! That's how I imagined the conversation would go. Thanks Sean!
There was a problem hiding this comment.
I might have missed why we could remove it. Mind refreshing my memory @srowen (sorry getting too old :))
There was a problem hiding this comment.
Actually, leave this one. It does serve a purpose.
jaceklaskowski
force-pushed
the
sparkui-fixes
branch
from
6fcd247 to
8976018
Compare
There was a problem hiding this comment.
Actually, leave this one. It does serve a purpose.
There was a problem hiding this comment.
You might also change occurrences of "appUIAddress" in places like this test name. Have a look with a search and replace.
There was a problem hiding this comment.
Thanks Sean! How do you manage to find so much time to help people like me?!?! You're certainly not a robot -- I do know it since I met you few times and can confirm ;-)
There was a problem hiding this comment.
What do you think about renaming spark.driver.appUIAddress to spark.driver.webUrl? Not necessarily important, but merely for the sake of consistency...
|
Test build #67705 has finished for PR 15603 at commit
|
jaceklaskowski
force-pushed
the
sparkui-fixes
branch
from
88da49f to
7d65d49
Compare
jaceklaskowski
changed the title
|
Test build #67754 has finished for PR 15603 at commit
|
| val splitUIAddress = ui.webUrl.split(':') | ||
| val boundPort = ui.boundPort | ||
| assert(splitUIAddress(2).toInt == boundPort) | ||
| assert(splitUIAddress(3).toInt == boundPort) |
There was a problem hiding this comment.
I think this actually should not change. The test fails and the behavior should be identical anyway.
|
Test build #67757 has finished for PR 15603 at commit
|
|
The test failure doesn't seem to be due to my change. |
|
Test build #3379 has finished for PR 15603 at commit
|
|
Anything else you'd change/remove/add, Mr @srowen? |
|
Since this turned into a bit more of a change than where it started, and because it removes a method (internal, defunct as it may be), and since this isn't a hurry, would you open a JIRA just to track it for the record? |
jaceklaskowski
changed the title
## What changes were proposed in this pull request? Removing `appUIAddress` attribute since it is no longer in use. ## How was this patch tested? Local build Author: Jacek Laskowski <[email protected]> Closes apache#15603 from jaceklaskowski/sparkui-fixes.
3 participants
What changes were proposed in this pull request?
Removing
appUIAddressattribute since it is no longer in use.How was this patch tested?
Local build