[SPARK-17827][SQL]maxColLength type should be Int for String and Binary #15464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Oct 13, 2016
| values.count(_.isEmpty).toLong, | ||
| nonNullValues.map(_.length).sum / nonNullValues.length.toDouble, | ||
| nonNullValues.map(_.length).max.toLong, | ||
| nonNullValues.map(_.length).max.toInt, |
Member
There was a problem hiding this comment.
Does it even need toInt? I would presume it's already an int, but not sure.
Member
Author
There was a problem hiding this comment.
Good question, but at least it documents the type
Contributor
There was a problem hiding this comment.
I think we can keep toInt, it explicitly shows the type.
Contributor
|
LGTM |
Member
Author
|
This PR contains a change to o.a.s.sql.hive.StatisticsSuite which I believe should fix that issue (awaiting big-endian build to complete) |
Member
Author
|
Tests all pass on big-endian with this PR |
|
Test build #66892 has finished for PR 15464 at commit
|
Contributor
|
Merging to master. Thanks! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? correct the expected type from Length function to be Int ## How was this patch tested? Test runs on little endian and big endian platforms Author: Pete Robbins <[email protected]> Closes apache#15464 from robbinspg/SPARK-17827.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? correct the expected type from Length function to be Int ## How was this patch tested? Test runs on little endian and big endian platforms Author: Pete Robbins <[email protected]> Closes apache#15464 from robbinspg/SPARK-17827.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
correct the expected type from Length function to be Int
How was this patch tested?
Test runs on little endian and big endian platforms