[SPARK-17903][SQL] MetastoreRelation should talk to external catalog instead of hive client #15460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #66882 has finished for PR 15460 at commit
|
|
Test build #66893 has finished for PR 15460 at commit
|
Contributor
|
cc @ericl |
Contributor
|
LGTM |
Contributor
|
A bunch of mysterious failures ... |
Contributor
|
LGTM if tests pass :) |
Contributor
|
|
gatorsmile
reviewed
Oct 14, 2016
| client.getPartitions(db, table, partialSpec) | ||
| } | ||
|
|
||
| override def listPartitionsByFilter( |
Member
There was a problem hiding this comment.
Need a test case in HiveExternalCatalogSuite, just like the other APIs?
Member
|
LGTM except one comment about test case |
|
Test build #66922 has finished for PR 15460 at commit
|
|
Test build #66948 has finished for PR 15460 at commit
|
Contributor
Author
|
thanks for the review, merging to master! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
…instead of hive client ## What changes were proposed in this pull request? `HiveExternalCatalog` should be the only interface to talk to the hive metastore. In `MetastoreRelation` we can just use `ExternalCatalog` instead of `HiveClient` to interact with hive metastore, and add missing API in `ExternalCatalog`. ## How was this patch tested? existing tests. Author: Wenchen Fan <[email protected]> Closes apache#15460 from cloud-fan/relation.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…instead of hive client ## What changes were proposed in this pull request? `HiveExternalCatalog` should be the only interface to talk to the hive metastore. In `MetastoreRelation` we can just use `ExternalCatalog` instead of `HiveClient` to interact with hive metastore, and add missing API in `ExternalCatalog`. ## How was this patch tested? existing tests. Author: Wenchen Fan <[email protected]> Closes apache#15460 from cloud-fan/relation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HiveExternalCatalogshould be the only interface to talk to the hive metastore. InMetastoreRelationwe can just useExternalCataloginstead ofHiveClientto interact with hive metastore, and add missing API inExternalCatalog.How was this patch tested?
existing tests.