Skip to content

[MINOR][PySpark][DOCS] Fix examples in PySpark documentation #15242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 5 commits into from
Closed

[MINOR][PySpark][DOCS] Fix examples in PySpark documentation #15242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ac3088
Fix examples in PyPpark documentation
HyukjinKwon Sep 26, 2016
3a14788
Fix indentation in foreachPartition example
HyukjinKwon Sep 27, 2016
88c1069
Fix another example in mllib
HyukjinKwon Sep 27, 2016
85cda01
Remove \\
HyukjinKwon Sep 27, 2016
6de11ec
Add missing ...
HyukjinKwon Sep 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/pyspark/sql/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class DataFrame(object):
people = sqlContext.read.parquet("...")
department = sqlContext.read.parquet("...")

people.filter(people.age > 30).join(department, people.deptId == department.id)\
people.filter(people.age > 30).join(department, people.deptId == department.id) \\
.groupBy(department.name, "gender").agg({"salary": "avg", "age": "max"})

.. versionadded:: 1.3
Expand Down
6 changes: 3 additions & 3 deletions python/pyspark/sql/streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,9 @@ def load(self, path=None, format=None, schema=None, **options):
:param schema: optional :class:`pyspark.sql.types.StructType` for the input schema.
:param options: all other string options

>>> json_sdf = spark.readStream.format("json")\
.schema(sdf_schema)\
.load(tempfile.mkdtemp())
>>> json_sdf = spark.readStream.format("json") \\
Copy link
Member

@srowen srowen Sep 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, does the \ vs \ make the difference here? are there possibly other instances of this?

Copy link
Member Author

@HyukjinKwon HyukjinKwon Sep 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems it does. I took a look and a sweep before - #14063

I will take another look across the documentation again tomorrow.

... .schema(sdf_schema) \\
... .load(tempfile.mkdtemp())
>>> json_sdf.isStreaming
True
>>> json_sdf.schema == sdf_schema
Expand Down