Skip to content

[SPARK-17652] Fix confusing exception message while reserving capacity #15225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sameeragarwal wants to merge 1 commit into from
Closed

[SPARK-17652] Fix confusing exception message while reserving capacity #15225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,19 +285,19 @@ public void reserve(int requiredCapacity) {
try {
reserveInternal(newCapacity);
} catch (OutOfMemoryError outOfMemoryError) {
throwUnsupportedException(newCapacity, requiredCapacity, outOfMemoryError);
throwUnsupportedException(requiredCapacity, outOfMemoryError);
}
} else {
throwUnsupportedException(newCapacity, requiredCapacity, null);
throwUnsupportedException(requiredCapacity, null);
}
}
}

private void throwUnsupportedException(int newCapacity, int requiredCapacity, Throwable cause) {
String message = "Cannot reserve more than " + newCapacity +
" bytes in the vectorized reader (requested = " + requiredCapacity + " bytes). As a" +
" workaround, you can disable the vectorized reader by setting "
+ SQLConf.PARQUET_VECTORIZED_READER_ENABLED().key() + " to false.";
private void throwUnsupportedException(int requiredCapacity, Throwable cause) {
String message = "Cannot reserve additional contiguous bytes in the vectorized reader " +
"(requested = " + requiredCapacity + " bytes). As a workaround, you can disable the " +
"vectorized reader by setting " + SQLConf.PARQUET_VECTORIZED_READER_ENABLED().key() +
" to false.";
Copy link
Contributor

@yhuai yhuai Sep 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to also explain what's the cause of this error in the error message?

Copy link
Member Author

@sameeragarwal sameeragarwal Sep 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the first line work: Cannot reserve additional contiguous bytes in the vectorized reader? Do you have something in mind?

Copy link
Contributor

@yhuai yhuai Sep 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I was thinking if we can explain the reason that fails the allocation instead of just saying we cannot allocate mem.


if (cause != null) {
throw new RuntimeException(message, cause);
Expand Down
4 changes: 2 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,8 +802,8 @@ class ColumnarBatchSuite extends SparkFunSuite {
// Over-allocating beyond MAX_CAPACITY throws an exception
column.appendBytes(10, 0.toByte)
}
assert(ex.getMessage.contains(s"Cannot reserve more than ${column.MAX_CAPACITY} bytes in " +
s"the vectorized reader"))
assert(ex.getMessage.contains(s"Cannot reserve additional contiguous bytes in the " +
s"vectorized reader"))
}
}
}