[SPARK-15703][SCHEDULER][CORE][WEBUI] Make ListenerBus event queue size configurable (branch 2.0) #15222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze configurable
This change adds a new configuration entry to specify the size of the spark listener bus event queue. The value for this config ("spark.scheduler.listenerbus.eventqueue.size") is set to a default to 10000.
Note:
I haven't currently documented the configuration entry. We can decide whether it would be appropriate to make it a public configuration or keep it as an undocumented one. Refer JIRA for more details.
Ran existing jobs and verified the event queue size with debug logs and from the Spark WebUI Environment tab.
Author: Dhruve Ashar <[email protected]>
Closes #14269 from dhruve/bug/SPARK-15703.
Member
Author
|
/cc @yhuai |
yhuai
reviewed
Sep 23, 2016
| throw new SparkException("spark.scheduler.listenerbus.eventqueue.size must be > 0!") | ||
| } | ||
| queueSize | ||
| } |
Contributor
There was a problem hiding this comment.
This part is kind of weird. Seems there is no need to make EVENT_QUEUE_CAPACITY and eventQueue lazy vals since we pass the spark context to the constructor?
Member
Author
There was a problem hiding this comment.
This is created in SparkContext's constructor before conf is created.
Contributor
|
lgtm |
|
Test build #65840 has finished for PR 15222 at commit
|
Member
Author
|
Thanks! Merging to 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Sep 23, 2016
…ze configurable (branch 2.0) ## What changes were proposed in this pull request? Backport #14269 to 2.0. ## How was this patch tested? Jenkins. Author: Dhruve Ashar <[email protected]> Closes #15222 from zsxwing/SPARK-15703-2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport #14269 to 2.0.
How was this patch tested?
Jenkins.