[SPARK-17603] [SQL] Utilize Hive-generated Statistics For Partitioned Tables #15158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #65634 has finished for PR 15158 at commit
|
Member
Author
cloud-fan
reviewed
Sep 20, 2016
| // For partitioned tables, get the size of all the partitions. | ||
| // Note: the statistics might not be gathered for all the partitions. | ||
| // For partial collection, we will not utilize the Hive-generated statistics. | ||
| private def getTotalTableSize(statType: String): Option[Long] = { |
Contributor
There was a problem hiding this comment.
what if a query only reads some partitions? Looks like the table statistics depend on partition pruning.
Member
Author
There was a problem hiding this comment.
: ) We are facing the same issue in both data source tables and hive tables. That requires another PR to change how we use the statistics of leaf nodes. Partition filtering on statistics should be considered by the Filter nodes. Is my understanding right?
|
Test build #73853 has finished for PR 15158 at commit
|
Contributor
|
hmm, isn't is still valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For non-partitioned tables, Hive-generated statistics are stored in table properties. However, for partitioned tables, Hive-generated statistics are stored in partition properties. Thus, we are unable to utilize the Hive-generated statistics for partitioned tables.
The statistics might not be gathered for all the partitions in Hive. For partial collection, we will not utilize the Hive-generated statistics.
How was this patch tested?
Added test cases.