Skip to content

[SPARK-17581] [SQL] Invalidate Statistics After Some ALTER TABLE Commands [WIP] #15136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 1 commit into from
Closed

[SPARK-17581] [SQL] Invalidate Statistics After Some ALTER TABLE Commands [WIP] #15136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,8 @@ case class AlterTableSetLocationCommand(
} else {
table.withNewStorage(locationUri = Some(location))
}
catalog.alterTable(newTable)
val newTableWithInvalidatedStats = newTable.copy(stats = None)
catalog.alterTable(newTableWithInvalidatedStats)
}
Seq.empty[Row]
}
Expand Down
21 changes: 21 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,27 @@ class StatisticsSuite extends QueryTest with TestHiveSingleton with SQLTestUtils
}
}

test("alter table set location after analyze table") {
val textTable = "textTable"
withTable(textTable) {
sql(s"CREATE TABLE $textTable (key STRING, value STRING) STORED AS TEXTFILE")
sql(s"INSERT INTO TABLE $textTable SELECT * FROM src")
sql(s"ANALYZE TABLE $textTable COMPUTE STATISTICS")
checkStats(
textTable, isDataSourceTable = false, hasSizeInBytes = true, expectedRowCounts = Some(500))

withTempDir { tmpDir =>
val path = tmpDir.getCanonicalPath
sql(s"ALTER TABLE $textTable SET LOCATION '$path'")
checkStats(
textTable,
isDataSourceTable = false,
hasSizeInBytes = false,
Copy link
Member Author

@gatorsmile gatorsmile Sep 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the PR: #14971, we can reuse the Hive-generated statistics. Thus, this value will be true.

expectedRowCounts = None)
}
}
}

test("test table-level statistics for data source table created in HiveExternalCatalog") {
val parquetTable = "parquetTable"
withTable(parquetTable) {
Expand Down