SPARK-17532: Add lock debugging info to thread dumps. #15088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #65336 has finished for PR 15088 at commit
|
Member
There was a problem hiding this comment.
How about using Option instead of negative/null values? not much difference either way. I'm not sure if thread IDs can be negative ever.
Contributor
Author
There was a problem hiding this comment.
Probably cleaner that way. I was passing on what JMX returns, but I think you're right that we should translate to Scala expectations.
This adds information to the web UI thread dump page about the JVM locks held by threads and the locks that threads are blocked waiting to acquire. This should help find cases where lock contention is causing Spark applications to run slowly.
rdblue
force-pushed
the
SPARK-17532-add-thread-lock-info
branch
from
f49b6aa to
90bd2c8
Compare
|
Test build #65380 has finished for PR 15088 at commit
|
Contributor
Author
|
@srowen, could you take another look at this? It has been useful for us to catch locking issues and I'd like to get it in for 2.1.0. Thanks! |
Contributor
Author
|
@srowen, if you have a chance, could you look at this again? I think it will be helpful for tracking down live-lock issues. Thanks! |
Contributor
|
Thanks - merging in master/branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Nov 2, 2016
## What changes were proposed in this pull request? This adds information to the web UI thread dump page about the JVM locks held by threads and the locks that threads are blocked waiting to acquire. This should help find cases where lock contention is causing Spark applications to run slowly. ## How was this patch tested? Tested by applying this patch and viewing the change in the web UI.  Additions: - A "Thread Locking" column with the locks held by the thread or that are blocking the thread - Links from the a blocked thread to the thread holding the lock - Stack frames show where threads are inside `synchronized` blocks, "holding Monitor(...)" Author: Ryan Blue <[email protected]> Closes #15088 from rdblue/SPARK-17532-add-thread-lock-info. (cherry picked from commit 2dc0480) Signed-off-by: Reynold Xin <[email protected]>
Contributor
Author
|
Thanks @rxin! |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? This adds information to the web UI thread dump page about the JVM locks held by threads and the locks that threads are blocked waiting to acquire. This should help find cases where lock contention is causing Spark applications to run slowly. ## How was this patch tested? Tested by applying this patch and viewing the change in the web UI.  Additions: - A "Thread Locking" column with the locks held by the thread or that are blocking the thread - Links from the a blocked thread to the thread holding the lock - Stack frames show where threads are inside `synchronized` blocks, "holding Monitor(...)" Author: Ryan Blue <[email protected]> Closes apache#15088 from rdblue/SPARK-17532-add-thread-lock-info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This adds information to the web UI thread dump page about the JVM locks
held by threads and the locks that threads are blocked waiting to
acquire. This should help find cases where lock contention is causing
Spark applications to run slowly.
How was this patch tested?
Tested by applying this patch and viewing the change in the web UI.
Additions:
synchronizedblocks, "holding Monitor(...)"