[SPARK-16961] [Follow-up] [SparkR] More robust test case for spark.gaussianMixture. #14730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #64136 has finished for PR 14730 at commit
|
Member
|
OK sounds good, thank you @yanboliang . It passed the PR builder but I see why this is a better test. |
Member
|
LGTM |
Contributor
Author
|
Merged into master. Thanks for review. |
Member
|
I was going to merge back to 2.0 but it looks like this file doesn't exist in 2.0? just double checking I didn't miss something. |
Contributor
Author
|
Yes, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#14551 fixed off-by-one bug in
randomizeInPlaceand some test failure caused by this fix.But for SparkR
spark.gaussianMixturetest case, the fix is inappropriate. It only changed the output result of native R which should be compared by SparkR, however, it did not change the R code in annotation which is used for reproducing the result in native R. It will confuse users who can not reproduce the same result in native R. This PR sends a more robust test case which can produce same result between SparkR and native R.How was this patch tested?
Unit test update.