Skip to content

SPARK-1478.2 Fix incorrect NioServerSocketChannelFactory constructor call #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srowen wants to merge 1 commit into from
Closed

SPARK-1478.2 Fix incorrect NioServerSocketChannelFactory constructor call #1466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeInputDStream.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,15 @@ class FlumeReceiver(

private def initServer() = {
if (enableDecompression) {
val channelFactory = new NioServerSocketChannelFactory
(Executors.newCachedThreadPool(), Executors.newCachedThreadPool());
val channelPipelieFactory = new CompressionChannelPipelineFactory()
val channelFactory = new NioServerSocketChannelFactory(Executors.newCachedThreadPool(),
Executors.newCachedThreadPool())
val channelPipelineFactory = new CompressionChannelPipelineFactory()
Copy link
Contributor

@tdas tdas Jul 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the spelling mistake!


new NettyServer(
responder,
new InetSocketAddress(host, port),
channelFactory,
channelPipelieFactory,
channelFactory,
channelPipelineFactory,
Copy link
Contributor

@tdas tdas Jul 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed here? Was there a formatting issue?

Copy link
Member Author

@srowen srowen Jul 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a typo in the variable name. The other line was just the IDE
stripping a trailing space I think.
On Jul 17, 2014 7:52 PM, "Tathagata Das" [email protected] wrote:

In
external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeInputDStream.scala:

   new NettyServer(
     responder,
     new InetSocketAddress(host, port),

  •    channelFactory,

  •    channelPipelieFactory,

  •    channelFactory,

  •    channelPipelineFactory,

What changed here? Was there a formatting issue?

—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/1466/files#r15076612.

null)
} else {
new NettyServer(responder, new InetSocketAddress(host, port))
Expand Down