Skip to content

Add rand(numRows: Int, numCols: Int) functions #14422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xubo245 wants to merge 2 commits into from
Closed

Add rand(numRows: Int, numCols: Int) functions #14422

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7a1261
Add rand(numRows: Int, numCols: Int) functions
xubo245 Jul 30, 2016
054b70c
fix RNG
xubo245 Jul 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,20 @@ object DenseMatrix {
new DenseMatrix(numRows, numCols, Array.fill(numRows * numCols)(rng.nextDouble()))
}

/**
* Generate a `DenseMatrix` consisting of `i.i.d.` uniform random numbers.
*
* @param numRows number of rows of the matrix
* @param numCols number of columns of the matrix
* @return DenseMatrix` with size `numRows` x `numCols` and values in U(0, 1)
*/
@Since("2.0.0")
def rand(numRows: Int, numCols: Int): DenseMatrix = {
require(numRows.toLong * numCols <= Int.MaxValue,
s"$numRows x $numCols dense matrix is too large to allocate")
new DenseMatrix(numRows, numCols, Array.fill(numRows * numCols)((new Random).nextDouble()))

@srowen srowen Jul 30, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a new RNG for every element, which isn't great.

@xubo245 xubo245 Jul 30, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can fix RNG, This makes a new RNG for all element :
val rng = new Random()
new DenseMatrix(numRows, numCols, Array.fill(numRows * numCols)(rng.nextDouble()))

}

/**
* Generate a `DenseMatrix` consisting of `i.i.d.` gaussian random numbers.
* @param numRows number of rows of the matrix
Expand Down