[SPARK-16646][SQL] LEAST and GREATEST doesn't accept numeric arguments with different data types#14294
Closed
HyukjinKwon wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-16646][SQL] LEAST and GREATEST doesn't accept numeric arguments with different data types#14294HyukjinKwon wants to merge 2 commits intoapache:masterfrom
HyukjinKwon wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
@liancheng and @davies Will this change be appropriate? Could you please take a look? |
|
Test build #62652 has finished for PR 14294 at commit
|
|
Test build #62653 has finished for PR 14294 at commit
|
Member
Author
|
retest this please |
|
Test build #62657 has finished for PR 14294 at commit
|
This was referenced Jul 27, 2016
Member
Author
|
Closing this. Please refer https://issues.apache.org/jira/browse/SPARK-16646 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes
LEASTandGREATESTaccept other numeric types (Decimal). This worked fine inHiveContextin 1.6 because , for example,1.5wasDoubleTypein there.So, this finds a tightest common type from both
IntegerTypeandDoubleTypeasDoubleType, then it works okay.But currently it seems
1.5is being treated asDecimalTypefor now. So, It casts 1.5 as decimal(2, 1). So, it fails to find a tightest common type from bothIntegerTypeandDecimalType(2, 1).This PR introduces new function
findTightestCommonTypeToDecimaldealing with decimals interacting with each other or with primitive types. This logic is borrowed from JSON schema inference.How was this patch tested?
Unit tests in
TypeCoercionSuiteandDataFrameFunctionsSuite.