[SPARK-16476] Restructure MimaExcludes for easier union excludes#14128
Closed
rxin wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-16476] Restructure MimaExcludes for easier union excludes#14128rxin wants to merge 1 commit intoapache:masterfrom
rxin wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #62066 has finished for PR 14128 at commit
|
Contributor
Author
|
I'm going to merge this since this is a simple formatting change. I will submit a patch that updates the pom files and show what this can do. |
Contributor
Author
|
Merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
## What changes were proposed in this pull request? It is currently fairly difficult to have proper mima excludes when we cut a version branch. I'm proposing a small change to take the exclude list out of the exclude function, and put it in a variable so we can easily union excludes. After this change, we can bump pom.xml version to 2.1.0-SNAPSHOT, without bumping the diff base version. Note that I also deleted all the exclude rules for version 1.x, to cut down the size of the file. ## How was this patch tested? N/A - this is a build infra change. Author: Reynold Xin <rxin@databricks.com> Closes #14128 from rxin/SPARK-16476. (cherry picked from commit 52b5bb0) Signed-off-by: Reynold Xin <rxin@databricks.com>
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
## What changes were proposed in this pull request? After SPARK-16476 (committed earlier today as #14128), we can finally bump the version number. ## How was this patch tested? N/A Author: Reynold Xin <rxin@databricks.com> Closes #14130 from rxin/SPARK-16477.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It is currently fairly difficult to have proper mima excludes when we cut a version branch. I'm proposing a small change to take the exclude list out of the exclude function, and put it in a variable so we can easily union excludes.
After this change, we can bump pom.xml version to 2.1.0-SNAPSHOT, without bumping the diff base version. Note that I also deleted all the exclude rules for version 1.x, to cut down the size of the file.
How was this patch tested?
N/A - this is a build infra change.