Skip to content

[SPARK-16453] [BUILD] release-build.sh is missing hive-thriftserver for scala 2.10 #14108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yhuai wants to merge 2 commits into from
Closed

[SPARK-16453] [BUILD] release-build.sh is missing hive-thriftserver for scala 2.10 #14108

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5327a5b
[SPARK-16453] [BUILD] release-build.sh is missing hive-thriftserver f…
yhuai Jul 8, 2016
35ab3f2
Update
yhuai Jul 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/create-release/release-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ if [[ "$1" == "publish-snapshot" ]]; then
-Phive-thriftserver deploy
./dev/change-scala-version.sh 2.10
$MVN -DzincPort=$ZINC_PORT -Dscala-2.10 --settings $tmp_settings \
-DskipTests $PUBLISH_PROFILES clean deploy
-DskipTests $PUBLISH_PROFILES -Phive-thriftserver clean deploy

@srowen srowen Jul 8, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in PUBLISH_PROFILES?

@JoshRosen JoshRosen Jul 8, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I think the only reason that it wasn't there to begin with was because Scala 2.11 didn't always support the Hive ThriftServer. Let's move it there and also update line 258.

@yhuai yhuai Jul 8, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right. Let me move it to there.

@yhuai yhuai Jul 8, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.


# Clean-up Zinc nailgun process
/usr/sbin/lsof -P |grep $ZINC_PORT | grep LISTEN | awk '{ print $2; }' | xargs kill
Expand Down Expand Up @@ -297,7 +297,7 @@ if [[ "$1" == "publish-release" ]]; then
./dev/change-scala-version.sh 2.10

$MVN -DzincPort=$ZINC_PORT -Dmaven.repo.local=$tmp_repo -Dscala-2.10 \
-DskipTests $PUBLISH_PROFILES clean install
-DskipTests $PUBLISH_PROFILES -Phive-thriftserver clean install

# Clean-up Zinc nailgun process
/usr/sbin/lsof -P |grep $ZINC_PORT | grep LISTEN | awk '{ print $2; }' | xargs kill
Expand Down