Skip to content

Conversation

@zasdfgbnm
Copy link
Contributor

What changes were proposed in this pull request?

I add some shell scripts to support running master and slave foreground, which makes it more convenient to write systemd service and run on HPC.

How was this patch tested?

I test it manually and it works well on my computer

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@HyukjinKwon
Copy link
Member

(I think It might be nicer if this contribution follows https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark)

@zasdfgbnm zasdfgbnm changed the title Spark daemon run.sh [SPARK-16352] Spark daemon run.sh Jul 2, 2016
@zasdfgbnm
Copy link
Contributor Author

I see similar pull request here:
#3881

But I didn't get what happened to that and why it was closed without adding any support for running in foreground.

@srowen
Copy link
Member

srowen commented Jul 2, 2016

Please don't open a duplicate JIRA. You can see the discussion on the previous issue and JIRA, which is WontFix, mostly because it ultimately wasn't followed up on. It's not out of the quesiton but you should comment on the JIRA with details about why you think it's important first.

@zasdfgbnm
Copy link
Contributor Author

zasdfgbnm commented Jul 2, 2016

I followed that PR (#3881)

"I was under the impression all the shell scripts were getting refactored and that this patch had become obsolete. I agree it's best to close this out." by @hellertime

I'm not sure what happened to that. It seems that the previous PR was closed because the scripts had changed a lot before that PR was merged.

I didn't see anything that support running in foreground and nobody mentioned in that issue that running in foreground is useless and will never be supported.

"This patch has mostly gone stale at this point and I would recommend that we close it for now. If you prefer feel free to open a new updated one." by @andrewor14
I would say, this is the updated one.

@srowen
Copy link
Member

srowen commented Jul 2, 2016

I'm suggesting you keep the conversation together with the original JIRA, at least. I don't know if it was going to be merged or not, but it was not updated by the author in any event.

@zasdfgbnm
Copy link
Contributor Author

OK, but will the status of the original JIRA keep being "won't fix", if someone decide to reopen the discussion on it?
Can anyone give a comment on whether the running on foreground feature are welcome in spark upstream?
Also, if there has already been a good solution to run in foreground easily enough (so that my PR will be useless), could anyone send me a link to the document describing this?

@srowen srowen mentioned this pull request Feb 2, 2017
@asfgit asfgit closed this in 20b4ca1 Feb 3, 2017
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Closes apache#15736
Closes apache#16309
Closes apache#16485
Closes apache#16502
Closes apache#16196
Closes apache#16498
Closes apache#12380
Closes apache#16764

Closes apache#14394
Closes apache#14204
Closes apache#14027
Closes apache#13690
Closes apache#16279

Author: Sean Owen <[email protected]>

Closes apache#16778 from srowen/CloseStalePRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants