[SPARK-12177][TEST] Removed test to avoid compilation issue in scala 2.10#13992
Closed
tdas wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-12177][TEST] Removed test to avoid compilation issue in scala 2.10#13992tdas wants to merge 1 commit intoapache:masterfrom
tdas wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
LGTM pending Jenkins. |
|
Test build #61532 has finished for PR 13992 at commit
|
Contributor
|
Merging to master and branch-2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Jun 30, 2016
…2.10 ## What changes were proposed in this pull request? The commented lines failed scala 2.10 build. This is because of change in behavior of case classes between 2.10 and 2.11. In scala 2.10, if companion object of a case class has explicitly defined apply(), then the implicit apply method is not generated. In scala 2.11 it is generated. Hence, the lines compile fine in 2.11 but not in 2.10. This simply comments the tests to fix broken build. Correct solution is pending. Author: Tathagata Das <[email protected]> Closes #13992 from tdas/SPARK-12177. (cherry picked from commit de8ab31) Signed-off-by: Cheng Lian <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The commented lines failed scala 2.10 build. This is because of change in behavior of case classes between 2.10 and 2.11. In scala 2.10, if companion object of a case class has explicitly defined apply(), then the implicit apply method is not generated. In scala 2.11 it is generated. Hence, the lines compile fine in 2.11 but not in 2.10.
This simply comments the tests to fix broken build. Correct solution is pending.