-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-9478] [ml] Add class weights to Random Forest #13851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eded(getCalculator & fromString method)
…he predictions are correct with Impurity=WeightedGini
… ProbClassifier, but changing the definition of Impurity and DecTreClassifier
…Strategy 3.make classweights can be passed when reconstructing the tree, including json read/write
… and reverting getOldStrategy to old versions
|
Can one of the admins verify this patch? |
|
@n-triple-a Could you please see my comment and provide your feedback on the JIRA? Also, in an effort to promote clear communication and reduce duplicated effort, it is common to comment on the JIRA that you intend to work on the task before work begins, especially on JIRAs like this one which have had others already doing work on it and require a significant amount of work. Thanks! |
|
Hi @n-triple-a is this still active? |
## What changes were proposed in this pull request? This PR proposes to close PRs ... - inactive to the review comments more than a month - WIP and inactive more than a month - with Jenkins build failure but inactive more than a month - suggested to be closed and no comment against that - obviously looking inappropriate (e.g., Branch 0.5) To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below: Closes apache#11129 Closes apache#12085 Closes apache#12162 Closes apache#12419 Closes apache#12420 Closes apache#12491 Closes apache#13762 Closes apache#13837 Closes apache#13851 Closes apache#13881 Closes apache#13891 Closes apache#13959 Closes apache#14091 Closes apache#14481 Closes apache#14547 Closes apache#14557 Closes apache#14686 Closes apache#15594 Closes apache#15652 Closes apache#15850 Closes apache#15914 Closes apache#15918 Closes apache#16285 Closes apache#16389 Closes apache#16652 Closes apache#16743 Closes apache#16893 Closes apache#16975 Closes apache#17001 Closes apache#17088 Closes apache#17119 Closes apache#17272 Closes apache#17971 Added: Closes apache#17778 Closes apache#17303 Closes apache#17872 ## How was this patch tested? N/A Author: hyukjinkwon <[email protected]> Closes apache#18017 from HyukjinKwon/close-inactive-prs.
What changes were proposed in this pull request?
This PR is to implement class weights support to Random Forest (and also Decision Tree). This is useful in handling unbalanced data in classification problems.
How was this patch tested?
Add a unit test in the
DecisionTreeClassifierSuite. Manual tests are also done locally on an unbalanced dataset.