Skip to content

[SPARK-16053][R] Add spark_partition_id in SparkR #13768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 3 commits into from
Closed

[SPARK-16053][R] Add spark_partition_id in SparkR #13768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7e471c
Add `spark_partition_id` in SparkR
dongjoon-hyun Jun 19, 2016
cbd54b2
Use new title/description convention.
dongjoon-hyun Jun 20, 2016
ddb2102
Update function description.
dongjoon-hyun Jun 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions R/pkg/NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ exportMethods("%in%",
"skewness",
"sort_array",
"soundex",
"spark_partition_id",
"stddev",
"stddev_pop",
"stddev_samp",
Expand Down
21 changes: 21 additions & 0 deletions R/pkg/R/functions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,6 +1179,27 @@ setMethod("soundex",
column(jc)
})

#' spark_partition_id
Copy link
Contributor

@shivaram shivaram Jun 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: The convention we are using in SparkR is to have a descriptive title for the function. So in this case it would be something like Return the partition ID as a column. (There might be other places which need to fixed to match this convention as well -- We discussed this in #13394

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jun 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. I'll fix them.

#'
#' Return the column for partition ID of the Spark task.
Copy link
Contributor

@shivaram shivaram Jun 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor nits:

  • To be consistent with the title this line can be Return the partition ID of the Spark task a SparkDataFrame column
  • I think nondeterministic is more suitable than indeterministic

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jun 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That seems better.

#' Note that this is indeterministic because it depends on data partitioning and
#' task scheduling.
#'
#' This is equivalent to the SPARK_PARTITION_ID function in SQL.
#'
#' @rdname spark_partition_id
#' @name spark_partition_id
#' @export
#' @examples
#' \dontrun{select(df, spark_partition_id())}
#' @note spark_partition_id since 2.0.0
setMethod("spark_partition_id",
signature(x = "missing"),
function() {
jc <- callJStatic("org.apache.spark.sql.functions", "spark_partition_id")
column(jc)
})

#' @rdname sd
#' @name stddev
setMethod("stddev",
Expand Down
4 changes: 4 additions & 0 deletions R/pkg/R/generics.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,6 +1126,10 @@ setGeneric("sort_array", function(x, asc = TRUE) { standardGeneric("sort_array")
#' @export
setGeneric("soundex", function(x) { standardGeneric("soundex") })

#' @rdname spark_partition_id
#' @export
setGeneric("spark_partition_id", function(x) { standardGeneric("spark_partition_id") })

Copy link
Member

@felixcheung felixcheung Jun 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this go to L1080? this should be sorted

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jun 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean before sd?
Currently, it is sorted already, isn't it?
soundex -> spark_partition_id -> stddev?

#' @rdname sd
#' @export
setGeneric("stddev", function(x) { standardGeneric("stddev") })
Expand Down
1 change: 1 addition & 0 deletions R/pkg/inst/tests/testthat/test_sparkSQL.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,6 +1058,7 @@ test_that("column functions", {
c16 <- is.nan(c) + isnan(c) + isNaN(c)
c17 <- cov(c, c1) + cov("c", "c1") + covar_samp(c, c1) + covar_samp("c", "c1")
c18 <- covar_pop(c, c1) + covar_pop("c", "c1")
c19 <- spark_partition_id()

# Test if base::is.nan() is exposed
expect_equal(is.nan(c("a", "b")), c(FALSE, FALSE))
Expand Down