Skip to content

Conversation

@squito
Copy link
Contributor

@squito squito commented Jun 6, 2016

What changes were proposed in this pull request?

There is still some flakiness in BlacklistIntegrationSuite, so turning it off for the moment to avoid breaking more builds -- will turn it back with more fixes.

How was this patch tested?

jenkins.

@SparkQA
Copy link

SparkQA commented Jun 6, 2016

Test build #60055 has finished for PR 13528 at commit a3c75da.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@squito
Copy link
Contributor Author

squito commented Jun 6, 2016

merged to master.

not closing the jira for now since I hope to actually fix the tests, not just turn them off

@squito
Copy link
Contributor Author

squito commented Jun 6, 2016

forgot to add -- I did look at the test failures, they are unrelated flakiness

@asfgit asfgit closed this in 36d3dfa Jun 6, 2016
@sameeragarwal
Copy link
Member

@squito the last master build failed a number of tests on this commit: https://spark-tests.appspot.com/builds/spark-master-test-maven-hadoop-2.2/1206. Could those failures be related?

@sameeragarwal
Copy link
Member

@squito
Copy link
Contributor Author

squito commented Jun 6, 2016

thanks @sameeragarwal , I took a look and reached more or less the same conclusion. I don't understand why a failure in LogUrlsStandaloneSuite isn't getting properly cleaned up -- all the right hooks for LocalSparkContext seem to be there -- but it certainly looks like the problem is related to that somehow, but maybe there is something there if anybody wants to track down the flakiness.

then again, I've been wrong about this test multiple times now, so please lemme know if there are continued issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants