[SPARK-15714][CORE] Fix flaky o.a.s.scheduler.BlacklistIntegrationSuite #13454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re we got a failure exception
…er; cleanup runningTasks
squito
changed the title
|
Test build #59778 has finished for PR 13454 at commit
|
| val newTasks = taskScheduler.resourceOffers(offers).flatten | ||
| val newTaskDescriptions = taskScheduler.resourceOffers(offers).flatten | ||
| // get the task now, since that requires a lock on TaskSchedulerImpl, to prevent individual | ||
| // tests for introducing a race if they need it |
Contributor
Author
|
thanks for the feedback @vanzin . I updated the comments slightly, which I hope addresses your concerns. |
|
Test build #59933 has finished for PR 13454 at commit
|
|
Test build #59935 has finished for PR 13454 at commit
|
Contributor
Author
|
ok as this seems to be failing quite commonly in some envs I'm going to merge this since it fixes the issue, but open to more feedback. |
Contributor
Author
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BlacklistIntegrationSuite (introduced by SPARK-10372) is a bit flaky because of some race conditions:
(1) has failed a handful of jenkins builds recently. I don't think I've seen (2) in jenkins, but I've run into with some uncommitted tests I'm working on where there are lots more tasks.
While I was in there, I also made an unrelated fix to
runningTasksin the test framework -- there was a pointlessO(n)operation to remove completed tasks, could beO(1).How was this patch tested?
I modified the o.a.s.scheduler.BlacklistIntegrationSuite to have it run the tests 1k times on my laptop. It failed 11 times before this change, and none with it. (Pretty sure all the failures were problem (1), though I didn't check all of them).
Also the full suite of tests via jenkins.