Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented May 13, 2016

What changes were proposed in this pull request?

Copy the linalg (Vector/Matrix and VectorUDT/MatrixUDT) in PySpark to new ML package.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58569 has finished for PR 13099 at commit 8515158.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MLlibTestCase(unittest.TestCase):
    • class VectorTests(MLlibTestCase):
    • class VectorUDTTests(MLlibTestCase):
    • class MatrixUDTTests(MLlibTestCase):

@viirya
Copy link
Member Author

viirya commented May 13, 2016

I will fix the style when I come back to laptop.

@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58572 has finished for PR 13099 at commit 479d5af.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented May 13, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58573 has finished for PR 13099 at commit 479d5af.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented May 14, 2016

ping @mengxr

@mengxr
Copy link
Contributor

mengxr commented May 16, 2016

I'm making a pass now.

@mengxr
Copy link
Contributor

mengxr commented May 17, 2016

@viirya I made one pass and sent you a PR at viirya#5. Please take a look and merge it if it looks good to you. Thanks!

@viirya
Copy link
Member Author

viirya commented May 17, 2016

retest this please.

@SparkQA
Copy link

SparkQA commented May 17, 2016

Test build #58671 has finished for PR 13099 at commit 7ff2021.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented May 17, 2016

LGTM. Merged into master and branch-2.0. Thanks!

asfgit pushed a commit that referenced this pull request May 17, 2016
## What changes were proposed in this pull request?

Copy the linalg (Vector/Matrix and VectorUDT/MatrixUDT) in PySpark to new ML package.

## How was this patch tested?
Existing tests.

Author: Xiangrui Meng <[email protected]>
Author: Liang-Chi Hsieh <[email protected]>
Author: Liang-Chi Hsieh <[email protected]>

Closes #13099 from viirya/move-pyspark-vector-matrix-udt4.

(cherry picked from commit 8ad9f08)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in 8ad9f08 May 17, 2016
@SparkQA
Copy link

SparkQA commented May 17, 2016

Test build #58670 has finished for PR 13099 at commit 7ff2021.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya viirya deleted the move-pyspark-vector-matrix-udt4 branch December 27, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants