[SPARK-14346][SQL] Native SHOW CREATE TABLE for Hive tables/views #13079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liancheng
changed the title
liancheng
changed the title
Contributor
Author
|
cc @yhuai @cloud-fan |
Contributor
|
test this please |
| } | ||
| builder ++= metadata.viewOriginalText.mkString(" AS\n", "", "\n") | ||
| } else { | ||
| showHiveTableDataColumns(metadata, builder) |
Contributor
There was a problem hiding this comment.
Should there be table comment clause generated here, after the data column list? COMMENT '.....'
|
Test build #58504 has finished for PR 13079 at commit
|
| * Note that Hive's metastore also tracks skewed columns. We should consider adding that in the | ||
| * future once we have a better understanding of how we want to handle skewed columns. | ||
| * | ||
| * Field `fullyMapped` is used to indicate whether all table metadata entries retrieved from the |
Contributor
There was a problem hiding this comment.
you can use @param here
|
Test build #58697 has finished for PR 13079 at commit
|
| throw new UnsupportedOperationException( | ||
| s"Failed to execute SHOW CREATE TABLE against table ${metadata.identifier.quotedString}, " + | ||
| "because it contains table structure(s) (e.g. skewed columns) that Spark SQL doesn't " + | ||
| "support yet." |
Contributor
There was a problem hiding this comment.
I think we need to explicitly say that the table was created by Hive with keywords that we do not support.
Contributor
Author
There was a problem hiding this comment.
Do you mean we should mention the exact keywords, or just saying that the table is created by Hive?
Contributor
Author
There was a problem hiding this comment.
Replaced hasUnsupportedFeatures: Boolean with unsupportedFeatures: Seq[String], which holds string descriptions of unsupported features, so that we can list them in the exception message.
Contributor
|
LGTM. I am merging this to master and 2.0. Let's change the error message and exception class in a separate pr. |
asfgit
pushed a commit
that referenced
this pull request
May 17, 2016
## What changes were proposed in this pull request? This is a follow-up of #12781. It adds native `SHOW CREATE TABLE` support for Hive tables and views. A new field `hasUnsupportedFeatures` is added to `CatalogTable` to indicate whether all table metadata retrieved from the concrete underlying external catalog (i.e. Hive metastore in this case) can be mapped to fields in `CatalogTable`. This flag is useful when the target Hive table contains structures that can't be handled by Spark SQL, e.g., skewed columns and storage handler, etc.. ## How was this patch tested? New test cases are added in `ShowCreateTableSuite` to do round-trip tests. Author: Cheng Lian <[email protected]> Closes #13079 from liancheng/spark-14346-show-create-table-for-hive-tables. (cherry picked from commit b674e67) Signed-off-by: Yin Huai <[email protected]>
|
|
||
| require(metadata.identifier.database == Some(databaseName), | ||
| require( | ||
| metadata.identifier.database.contains(databaseName), |
Contributor
There was a problem hiding this comment.
contains is not in scala 2.10. Let me fixing the build.
asfgit
pushed a commit
that referenced
this pull request
May 18, 2016
## What changes were proposed in this pull request? Scala 2.10 build was broken by #13079. I am reverting the change of that line. Author: Yin Huai <[email protected]> Closes #13157 from yhuai/SPARK-14346-fix-scala2.10. (cherry picked from commit 2a5db9c) Signed-off-by: Yin Huai <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
May 18, 2016
## What changes were proposed in this pull request? Scala 2.10 build was broken by #13079. I am reverting the change of that line. Author: Yin Huai <[email protected]> Closes #13157 from yhuai/SPARK-14346-fix-scala2.10.
asfgit
pushed a commit
that referenced
this pull request
May 19, 2016
…LE output ## What changes were proposed in this pull request? This PR is a follow-up of #13079. It replaces `hasUnsupportedFeatures: Boolean` in `CatalogTable` with `unsupportedFeatures: Seq[String]`, which contains unsupported Hive features of the underlying Hive table. In this way, we can accurately report all unsupported Hive features in the exception message. ## How was this patch tested? Updated existing test case to check exception message. Author: Cheng Lian <[email protected]> Closes #13173 from liancheng/spark-14346-follow-up.
asfgit
pushed a commit
that referenced
this pull request
May 19, 2016
…LE output ## What changes were proposed in this pull request? This PR is a follow-up of #13079. It replaces `hasUnsupportedFeatures: Boolean` in `CatalogTable` with `unsupportedFeatures: Seq[String]`, which contains unsupported Hive features of the underlying Hive table. In this way, we can accurately report all unsupported Hive features in the exception message. ## How was this patch tested? Updated existing test case to check exception message. Author: Cheng Lian <[email protected]> Closes #13173 from liancheng/spark-14346-follow-up. (cherry picked from commit 6ac1c3a) Signed-off-by: Andrew Or <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #12781. It adds native
SHOW CREATE TABLEsupport for Hive tables and views. A new fieldhasUnsupportedFeaturesis added toCatalogTableto indicate whether all table metadata retrieved from the concrete underlying external catalog (i.e. Hive metastore in this case) can be mapped to fields inCatalogTable. This flag is useful when the target Hive table contains structures that can't be handled by Spark SQL, e.g., skewed columns and storage handler, etc..How was this patch tested?
New test cases are added in
ShowCreateTableSuiteto do round-trip tests.