Skip to content

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented May 12, 2016

What changes were proposed in this pull request?

Seems db573fc did not remove withHiveSupport from readwrite.py

@yhuai
Copy link
Contributor Author

yhuai commented May 12, 2016

i have tested locally. It fixed the test. I am merging it to master and branch 2.0.

@asfgit asfgit closed this in ba5487c May 12, 2016
asfgit pushed a commit that referenced this pull request May 12, 2016
…ort from readwrite.py

## What changes were proposed in this pull request?
Seems db573fc did not remove withHiveSupport from readwrite.py

Author: Yin Huai <[email protected]>

Closes #13069 from yhuai/fixPython.

(cherry picked from commit ba5487c)
Signed-off-by: Yin Huai <[email protected]>
@SparkQA
Copy link

SparkQA commented May 12, 2016

Test build #58441 has finished for PR 13069 at commit f0a1fd1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@nchammas
Copy link
Contributor

Seems db573fc did not remove withHiveSupport from readwrite.py

@yhuai - It did, but I added it back in as part of this PR: https://github.com/apache/spark/pull/13034/files#diff-6d503df22b5f03cff987f1ccae32c1f4R878

What's the reason for the change to not use withHiveSupport()? The JIRA doesn't explain.

@yhuai
Copy link
Contributor Author

yhuai commented May 16, 2016

@nchammas It's part of the cleanup related to how we create SparkSession. Since with/without hive support is controlled by a conf, we replaced withHiveSupport with enableHiveSupport (this one just set the conf).

@nchammas
Copy link
Contributor

Okie doke, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants