-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-15094][SQL] Avoid extra Project when DeserializeToObject at top of logical plan #12898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #57761 has finished for PR 12898 at commit
|
|
Test build #57764 has finished for PR 12898 at commit
|
|
Test build #57837 has finished for PR 12898 at commit
|
|
Test build #57850 has finished for PR 12898 at commit
|
Conflicts: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
|
Test build #57954 has finished for PR 12898 at commit
|
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We will eliminate the pair of
DeserializeToObjectandSerializeFromObjectin optimizer and add extraProject. However, whenDeserializeToObject'soutputObjectTypeisObjectTypeand itsclscan't be processed by unsafe project, the projection will be failed.As the extra
Projectis used to preserve output expr id, if theDeserializeToObjectis at the top, we can avoid this extraProject.How was this patch tested?
DatasetSuite.