[SPARK-15062] [SQL] fix list type infer serializer issue #12849
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| test("SPARK-15062") { |
Contributor
There was a problem hiding this comment.
should document the test case more than just the issue number
Contributor
There was a problem hiding this comment.
is it possible to turn this into a unit test on scalareflection rather than an end-to-end test?
Contributor
|
is this original issue that i used List instead of Seq? if so, is this even an issue at all? Should i simply have used Seq? |
Contributor
Author
|
Making the changes based on the comments. Will post it shortly. |
|
Test build #57559 has finished for PR 12849 at commit
|
|
Test build #57568 has finished for PR 12849 at commit
|
Contributor
|
cc @marmbrus |
Contributor
|
Thanks, merging to master and 2.0 |
asfgit
pushed a commit
that referenced
this pull request
May 3, 2016
## What changes were proposed in this pull request? Make serializer correctly inferred if the input type is `List[_]`, since `List[_]` is type of `Seq[_]`, before it was matched to different case (`case t if definedByConstructorParams(t)`). ## How was this patch tested? New test case was added. Author: bomeng <[email protected]> Closes #12849 from bomeng/SPARK-15062. (cherry picked from commit 0fd95be) Signed-off-by: Michael Armbrust <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make serializer correctly inferred if the input type is
List[_], sinceList[_]is type ofSeq[_], before it was matched to different case (case t if definedByConstructorParams(t)).How was this patch tested?
New test case was added.