Skip to content

Conversation

@andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Apr 21, 2016

What changes were proposed in this pull request?

This removes the class HiveContext itself along with all code usages associated with it. The bulk of the work was already done in #12485. This is mainly just code cleanup and actually removing the class.

Note: A couple of things will break after this patch. These will be fixed separately.

How was this patch tested?

No change in functionality.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56593 has finished for PR 12585 at commit 0e16190.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2016

Test build #56592 has finished for PR 12585 at commit 8e6e2b1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin pushed a commit to rxin/spark that referenced this pull request Apr 22, 2016
## What changes were proposed in this pull request?

Just a rename so we can get rid of `HiveContext.scala`. Note that this will conflict with apache#12585.

## How was this patch tested?

No change in functionality.

Author: Andrew Or <[email protected]>

Closes apache#12586 from andrewor14/rename-hc-object.
@SparkQA
Copy link

SparkQA commented Apr 22, 2016

Test build #56617 has finished for PR 12585 at commit 069c8b6.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 22, 2016

Test build #56628 has finished for PR 12585 at commit f910821.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 22, 2016

Test build #56630 has finished for PR 12585 at commit c7bbb8f.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

Hm, seems that I'll need to fix the python thing in this patch.

@SparkQA
Copy link

SparkQA commented Apr 22, 2016

Test build #56722 has finished for PR 12585 at commit 188bcf0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Apr 23, 2016

Test build #56756 has finished for PR 12585 at commit 188bcf0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Apr 24, 2016

The changes look good to me.

@SparkQA
Copy link

SparkQA commented Apr 25, 2016

Test build #2868 has finished for PR 12585 at commit f59b869.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 25, 2016

Test build #56907 has finished for PR 12585 at commit f59b869.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 25, 2016

Test build #2869 has finished for PR 12585 at commit f59b869.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 25, 2016

Test build #2870 has finished for PR 12585 at commit f59b869.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Apr 25, 2016

LGTM

@andrewor14
Copy link
Contributor Author

Thanks merging into master.

@asfgit asfgit closed this in 3c5e65c Apr 25, 2016
@andrewor14 andrewor14 deleted the delete-hive-context branch April 25, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants